Skip to content

add password mode to hide/reveal text in NTextInput #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gokomer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add password mode to hide/reveal text in NTextInput #2339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Assets/Translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,7 @@
"general": "General",
"height": "Height",
"hibernate": "Hibernate",
"hide-password": "Hide password",
"history": "History",
"icon": "Icon",
"idle": "Idle",
Expand Down Expand Up @@ -518,6 +519,7 @@
"settings": "Settings",
"shortcuts": "Shortcuts",
"shutdown": "Shutdown",
"show-password": "Show password",
"signal": "Signal",
"sound": "Sound",
"sources": "Sources",
Expand Down
26 changes: 25 additions & 1 deletion Widgets/NTextInput.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ ColumnLayout {
property real radius: Style.iRadiusM
property real minimumInputWidth: 80 * Style.uiScaleRatio
property bool showClearButton: true
property bool passwordMode: false
property bool passwordVisible: false
property bool showPasswordToggle: false

property alias text: input.text
property alias placeholderText: input.placeholderText
Expand Down Expand Up @@ -149,7 +152,7 @@ ColumnLayout {

verticalAlignment: TextInput.AlignVCenter

echoMode: TextInput.Normal
echoMode: root.passwordMode && !root.passwordVisible ? TextInput.Password : TextInput.Normal
readOnly: root.readOnly
placeholderTextColor: Qt.alpha(Color.mOnSurfaceVariant, 0.6)
color: enabled ? Color.mOnSurface : Qt.alpha(Color.mOnSurface, 0.4)
Expand Down Expand Up @@ -231,6 +234,27 @@ ColumnLayout {
input.forceActiveFocus();
}
}

NIconButton {
id: passwordToggle
icon: root.passwordVisible ? "eye-off" : "eye"
tooltipText: (!root.readOnly && root.enabled) ? (root.passwordVisible ? I18n.tr("common.hide-password") : I18n.tr("common.show-password")) : ""

Layout.alignment: Qt.AlignVCenter
border.width: 0

colorBg: "transparent"
colorBgHover: "transparent"
colorFg: Color.mOnSurface
colorFgHover: Color.mError
visible: root.passwordMode && root.showPasswordToggle
enabled: !root.readOnly && root.enabled

onClicked: {
root.passwordVisible = !root.passwordVisible;
input.forceActiveFocus();
}
}
}
}
}
Expand Down