fix: desktop service crash-loop on startup notification failure - #183
Merged
Conversation
Banner notification failure (graphical-session.target race) triggered panic(), crash-looping the service. Demote to logrus.Warnf — banner is decorative; functional event notifications in handler() already use logrus.Errorf.
luochen1990
force-pushed
the
fix/desktop-startup-crash-loop
branch
from
August 1, 2026 13:25
df60b59 to
e85db72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On startup the banner notification may fire before the daemon is ready on
the session bus (common
graphical-session.targetrace).beeepfailsand
cmd/desktop.go:32panic(err)s, exiting code 2 and crash-looping:Fix
panic→logrus.Warnf. The banner is decorative; missing it doesn'taffect event subscription.
Mirrors
handler()in the same file (desktop.go:139useslogrus.Errorffor functional event notifications) but at lower severity— event misses cost the user build/deploy events, banner misses don't.
Complementary to #148 (adds a
Restart=fallback; this removes the root cause).Testing
go build && go vet && go testall pass; manually verified — startingbefore the daemon is ready now warns instead of panicking.