epoll: use from_bits_retain to avoid panics on unknown flags#2783
Open
kamalmarhubi wants to merge 1 commit intonix-rust:masterfrom
Open
epoll: use from_bits_retain to avoid panics on unknown flags#2783kamalmarhubi wants to merge 1 commit intonix-rust:masterfrom
kamalmarhubi wants to merge 1 commit intonix-rust:masterfrom
Conversation
EpollEvent::events() used from_bits().unwrap(), which panics if the kernel returns flags unknown to the current bitflags definition. Use from_bits_retain to preserve all bits without panicking.
kamalmarhubi
force-pushed
the
push-kvsnutkumzqs
branch
from
34f67da to
cb5c42a
Compare
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
EpollEvent::events() used from_bits().unwrap(), which panics if the kernel returns flags unknown to the current bitflags definition. Use from_bits_retain to preserve all bits without panicking.
Checklist:
CONTRIBUTING.md