moved psutil from test dep to core dep - #817
Open
tclose wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 87.89% 87.88% -0.02%
==========================================
Files 84 84
Lines 17890 17897 +7
Branches 3483 3484 +1
==========================================
+ Hits 15725 15729 +4
- Misses 1809 1814 +5
+ Partials 356 354 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I think we should endeavor to keep dependencies light, and core dependencies should be those necessary to access core functionality. If audits are core functionality, then fine, but otherwise we could create an |
Contributor
Author
|
I'm easy either way. An 'audit' extra sounds like a reasonable idea, we just need to make sure that audit isn't imported unless it is used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Summary
Adds
psutilas core dependency instead of just test. When resources are audited it imports thepydra.utils.profilermodule, which has psutil as a dep.Fixes #760
Checklist