Skip to content

moved psutil from test dep to core dep - #817

Open
tclose wants to merge 2 commits into
mainfrom
psutil-dep
Open

moved psutil from test dep to core dep#817
tclose wants to merge 2 commits into
mainfrom
psutil-dep

Conversation

@tclose

@tclose tclose commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Adds psutil as core dependency instead of just test. When resources are audited it imports the pydra.utils.profiler module, which has psutil as a dep.

Fixes #760

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov

codecov Bot commented Apr 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.88%. Comparing base (47c3958) to head (5ce4d1b).
⚠️ Report is 109 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   87.89%   87.88%   -0.02%     
==========================================
  Files          84       84              
  Lines       17890    17897       +7     
  Branches     3483     3484       +1     
==========================================
+ Hits        15725    15729       +4     
- Misses       1809     1814       +5     
+ Partials      356      354       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tclose
tclose requested a review from djarecka April 30, 2025 00:36
@effigies

effigies commented May 5, 2025

Copy link
Copy Markdown
Contributor

I think we should endeavor to keep dependencies light, and core dependencies should be those necessary to access core functionality.

If audits are core functionality, then fine, but otherwise we could create an audit extra and documentation that indicates that users wishing to use that functionality should install that extra.

@tclose

tclose commented May 5, 2025

Copy link
Copy Markdown
Contributor Author

I'm easy either way. An 'audit' extra sounds like a reasonable idea, we just need to make sure that audit isn't imported unless it is used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

psutil dependency missing for Audit features

2 participants