Skip to content

Remove logging of configuration parameters. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsorby wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove logging of configuration parameters. #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/sparc/client/services/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ def __init__(
self, config: Optional[Union[dict, SectionProxy]] = None, connect: bool = False
) -> None:
logging.info("Initializing SPARC K-Core Elasticsearch services...")
logging.debug(str(config))

self.host_api = "https://api.scicrunch.io/elastic/v1"
self.algolia_api = "https://api.scicrunch.io/elastic/v1/SPARC_Algolia_pr/_search"
Expand Down
8 changes: 3 additions & 5 deletions src/sparc/client/services/o2sparc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def get_job_log(self, job_id: str) -> TemporaryDirectory:

Returns:
--------
A tempfile.TemporaryDirectory holding the log files
A temporary directory. TemporaryDirectory holding the log files
"""
logfile_path: str = self._solvers_api.get_job_output_logfile(
self._solver.id, self._solver.version, job_id
Expand All @@ -157,7 +157,6 @@ class O2SparcService(ServiceBase):
def __init__(self, config: dict[str, Any] | SectionProxy | None = None, connect: bool = True) -> None:
config = config or {}
logging.info("Initializing o2sparc...")
logging.debug("%s", f"{config=}")

kwargs = {}
for name in ("host", "username", "password"):
Expand All @@ -167,10 +166,9 @@ def __init__(self, config: dict[str, Any] | SectionProxy | None = None, connect:
if value is not None:
kwargs[name] = value

logging.debug(f"Config arguments:{kwargs}")
configuration = osparc.Configuration(**kwargs)

# reuses profile-name from penssieve to set debug mode
# reuses profile-name from Pennsieve to set debug mode
profile_name = config.get("pennsieve_profile_name", "prod")
configuration.debug = profile_name == "test"

Expand All @@ -180,7 +178,7 @@ def __init__(self, config: dict[str, Any] | SectionProxy | None = None, connect:
self.connect()

def connect(self) -> osparc.ApiClient:
"""Explicitily initializes client pool (not required)"""
"""Explicitly initializes client pool (not required)"""
p = self._client.pool
logging.debug("%s was initialized", p)
return self._client
Expand Down