Skip to content

merge main

c01beeb
Select commit
Loading
Failed to load commit list.
Open

Refactor Instance Watcher #1490

merge main
c01beeb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 8, 2026 in 1s

84.90% (target 80.00%)

View this Pull Request on Codecov

84.90% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 79.12773% with 134 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.90%. Comparing base (5707ea1) to head (c01beeb).

Files with missing lines Patch % Lines
internal/nginx/nginx_plugin.go 78.87% 82 Missing and 8 partials ⚠️
...ernal/watcher/instance/instance_watcher_service.go 76.34% 17 Missing and 5 partials ⚠️
internal/nginx/nginx_service.go 72.88% 15 Missing and 1 partial ⚠️
...her/instance/nginx-app-protect-instance-watcher.go 83.78% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
- Coverage   85.07%   84.90%   -0.17%     
==========================================
  Files         105      104       -1     
  Lines       13691    13569     -122     
==========================================
- Hits        11647    11521     -126     
- Misses       1529     1534       +5     
+ Partials      515      514       -1     
Files with missing lines Coverage Δ
internal/file/file_manager_service.go 74.82% <ø> (ø)
internal/nginx/nginx_instance_operator.go 91.17% <ø> (ø)
internal/nginx/nginx_instance_process_operator.go 61.76% <ø> (ø)
internal/nginx/nginx_log_tailer_operator.go 86.66% <ø> (ø)
internal/nginx/nginx_plus_actions.go 97.60% <100.00%> (ø)
internal/plugin/plugin_manager.go 87.30% <100.00%> (-0.94%) ⬇️
internal/watcher/health/health_watcher_service.go 81.63% <100.00%> (-7.46%) ⬇️
internal/watcher/watcher_plugin.go 69.76% <100.00%> (-3.15%) ⬇️
...her/instance/nginx-app-protect-instance-watcher.go 80.00% <83.78%> (-2.69%) ⬇️
internal/nginx/nginx_service.go 59.74% <72.88%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5707ea1...c01beeb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.