drop ext.when in module template#4314
Open
matthdsm wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mashehu
reviewed
Jun 8, 2026
| return | ||
| if len(lines) > 1: | ||
| self.failed.append(("main_nf", "when_exist", "when: condition has too many lines", self.main_nf)) | ||
| self.passed.append(("main_nf", "when_exist", "No when: condition found", self.main_nf)) |
Contributor
There was a problem hiding this comment.
Suggested change
| self.passed.append(("main_nf", "when_exist", "No when: condition found", self.main_nf)) | |
| self.passed.append(("main_nf", "no_when", "No `when:` condition found", self.main_nf)) |
better to use a new linting rule name if the rule changed to the opposite
mashehu
reviewed
Jun 8, 2026
| self.failed.append(("main_nf", "when_exist", "when: condition has too many lines", self.main_nf)) | ||
| self.passed.append(("main_nf", "when_exist", "No when: condition found", self.main_nf)) | ||
| return | ||
| self.passed.append(("main_nf", "when_exist", "when: condition is present", self.main_nf)) |
Contributor
There was a problem hiding this comment.
this should also be removed then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
ext.whenusage in modulesxref: https://nfcore.slack.com/archives/C043UU89KKQ/p1780568879209299
PR checklist
CHANGELOG.mdis updateddocsis updated