Skip to content

Simplify badges further#1038

Merged
jfy133 merged 9 commits into
devfrom
new-badge-structure
May 20, 2026
Merged

Simplify badges further#1038
jfy133 merged 9 commits into
devfrom
new-badge-structure

Conversation

@jfy133

@jfy133 jfy133 commented May 20, 2026

Copy link
Copy Markdown
Member

Based on: nf-core/tools#4288 (comment)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions

github-actions Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1870ba5

+| ✅ 389 tests passed       |+
#| ❔   1 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-05-20 10:28:58

dialvarezs
dialvarezs approved these changes May 20, 2026
View reviewed changes

@dialvarezs dialvarezs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. It's definitively more clean.

@jfy133

jfy133 commented May 20, 2026

Copy link
Copy Markdown
Member Author

Also ave OK from maintainers team to adopt same thing in tools, so will push that there too

@jfy133 jfy133 merged commit 4b0783d into dev May 20, 2026
6 checks passed
@dialvarezs

dialvarezs commented May 20, 2026

Copy link
Copy Markdown
Member

Post-merge comment:
Now on a second look on the GitHub page, what about using the same color for all labels (right now we have some gray and some black)
image

@d4straub

d4straub commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Years ago I ranted about the non-uniform gray/black coloring, to no avail at the time :D
I.e. I agree!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dialvarezs dialvarezs dialvarezs approved these changes

@d4straub d4straub Awaiting requested review from d4straub d4straub is a code owner

@prototaxites prototaxites Awaiting requested review from prototaxites prototaxites is a code owner

@muabnezor muabnezor Awaiting requested review from muabnezor muabnezor is a code owner

Assignees

No one assigned

Labels

size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfy133 @dialvarezs @d4straub