Skip to content

FIX: strict syntax for alliance_canada#1069

Merged
CMonnin merged 2 commits intomasterfrom
alliance_canada
Apr 17, 2026
Merged

FIX: strict syntax for alliance_canada#1069
CMonnin merged 2 commits intomasterfrom
alliance_canada

Conversation

@maxulysse
Copy link
Copy Markdown
Member


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

@maxulysse
Copy link
Copy Markdown
Member Author

@jerryakii @MareikeJaniak @CMonnin I tried to update this config to work with the coming new syntax (cf https://nf-co.re/blog/2026/configs-strict-syntax).
Please have a look, and let us know if it's working for you

Comment thread conf/alliance_canada.config Outdated
@maxulysse maxulysse changed the title Fix: strict syntax for alliance_canada FIX: strict syntax for alliance_canada Apr 7, 2026
Comment thread conf/alliance_canada.config Outdated
@jfy133 jfy133 requested a review from MareikeJaniak April 17, 2026 08:25
Comment thread conf/alliance_canada.config Outdated
// Group name for resource allocation must be supplied as environment variable
process {
executor = 'slurm'
clusterOptions = "--account=${System.getenv('SLURM_ACCOUNT')}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter for the SLURM_ACCOUNT isn't getting passed with the new version of the config file, causing the pipeline to crash when it tries to submit jobs. I can't figure out why, though. As a sanity check, I just tested with the old version and it's working as expected.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the $SLURM_ACCOUNT was being overwritten to '' if you weren't on trillium

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's working now.

@CMonnin
Copy link
Copy Markdown
Contributor

CMonnin commented Apr 17, 2026

hello,
ive refactored the config to use $CC_CLUSTER instead of hostname as it's more robust.

@MareikeJaniak
Copy link
Copy Markdown
Contributor

I'm still getting this warning, but things do seem to run as expected:

WARN: The following invalid input values have been detected:

* --max_cpus: 192
* --max_time: 7d
* --max_memory: 750 GB
* --cluster_name: rorqual

@CMonnin
Copy link
Copy Markdown
Contributor

CMonnin commented Apr 17, 2026

I'm still getting this warning, but things do seem to run as expected:

WARN: The following invalid input values have been detected:

* --max_cpus: 192
* --max_time: 7d
* --max_memory: 750 GB
* --cluster_name: rorqual

What did you run?
@MareikeJaniak
I did some basic testing on the clusters, i just ran
nextflow -c conf/alliance_canada.config config and got the expected outputs.

@MareikeJaniak
Copy link
Copy Markdown
Contributor

@CMonnin I ran the rnaseq pipeline test described here:
https://docs.alliancecan.ca/wiki/Nextflow

Running nextflow -c conf/alliance_canada.config config does also give me the expected outputs.

@CMonnin
Copy link
Copy Markdown
Contributor

CMonnin commented Apr 17, 2026

@MareikeJaniak i believe the warnings are from the json schema. I think it's ok to ignore them for now. I'm ok with approving this

@CMonnin CMonnin merged commit 3cd58bf into master Apr 17, 2026
149 of 161 checks passed
@CMonnin CMonnin deleted the alliance_canada branch April 17, 2026 18:53
@maxulysse
Copy link
Copy Markdown
Member Author

@CMonnin You changed the startsWith back to ==, won't that cause issues on your side?

@CMonnin
Copy link
Copy Markdown
Contributor

CMonnin commented Apr 20, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants