Conversation
|
@jerryakii @MareikeJaniak @CMonnin I tried to update this config to work with the coming new syntax (cf https://nf-co.re/blog/2026/configs-strict-syntax). |
| // Group name for resource allocation must be supplied as environment variable | ||
| process { | ||
| executor = 'slurm' | ||
| clusterOptions = "--account=${System.getenv('SLURM_ACCOUNT')}" |
There was a problem hiding this comment.
The parameter for the SLURM_ACCOUNT isn't getting passed with the new version of the config file, causing the pipeline to crash when it tries to submit jobs. I can't figure out why, though. As a sanity check, I just tested with the old version and it's working as expected.
There was a problem hiding this comment.
looks like the $SLURM_ACCOUNT was being overwritten to '' if you weren't on trillium
There was a problem hiding this comment.
Thanks! It's working now.
|
hello, |
|
I'm still getting this warning, but things do seem to run as expected: |
What did you run? |
|
@CMonnin I ran the rnaseq pipeline test described here: Running |
|
@MareikeJaniak i believe the warnings are from the json schema. I think it's ok to ignore them for now. I'm ok with approving this |
code polish startsWith
119f129 to
f8bf579
Compare
|
@CMonnin You changed the startsWith back to ==, won't that cause issues on your side? |
|
I changed the check to use the env variable 'CC_CLUSER' which exists in
each cluster and is just the name of the cluster. It's easier to match now.
…On Mon, Apr 20, 2026, 3:34 a.m. Maxime U Garcia ***@***.***> wrote:
*maxulysse* left a comment (nf-core/configs#1069)
<#1069?email_source=notifications&email_token=A3CIGGCI5KWELGPDITY6RL34WXHIHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRXHA3DQNZUGQ3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4278687446>
@CMonnin <https://github.com/CMonnin> You changed the startsWith back to
==, won't that cause issues on your side?
—
Reply to this email directly, view it on GitHub
<#1069?email_source=notifications&email_token=A3CIGGCI5KWELGPDITY6RL34WXHIHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRXHA3DQNZUGQ3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4278687446>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3CIGGC2UDSXAQZXLP6326D4WXHIHAVCNFSM6AAAAACXPPGHMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DENZYGY4DONBUGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
name: New Config
about: A new cluster config
Please follow these steps before submitting your PR:
[WIP]in its titlemasterbranchSteps for adding a new config profile:
conf/directorydocs/directorynfcore_custom.configfile in the top-level directoryprofile:scope in.github/workflows/main.yml.github/CODEOWNERS(**/<custom-profile>** @<github-username>)