Skip to content

fix(windows): make Windows ARM64 build start and package correctly #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aequivalent2 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

fix(windows): make Windows ARM64 build start and package correctly #1809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/app/windows.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,20 @@ export function getWindowsRegistryItem(hive: HKEY, path: string, name: string):
throw new Error('getWindowsRegistryItem is only available on Windows')
}

if (process.arch !== 'x64') {
throw new Error('getWindowsRegistryItem is only available on x64')
if (process.arch !== 'x64' && process.arch !== 'arm64') {
throw new Error('getWindowsRegistryItem is only available on x64 and arm64')
}

let windowRegistry
try {
const require = createRequire(import.meta.url)
const windowRegistry = require('@vscode/windows-registry/prebuilds/win32-x64/@vscode+windows-registry.node')
windowRegistry = require(`@vscode/windows-registry/prebuilds/win32-${process.arch}/@vscode+windows-registry.node`)
} catch {
console.error('Error loading @vscode/windows-registry')
return undefined
Comment on lines 27 to +32
}

try {
return windowRegistry.GetStringRegKey(hive, path, name)
} catch (error) {
// 'Unable to open registry key' is expected when the registry key does not exist
Expand Down
Loading