Merged
Conversation
marcsanmi
reviewed
May 14, 2024
54dfd3d to
371ce6b
Compare
marcsanmi
approved these changes
May 14, 2024
Contributor
marcsanmi
left a comment
There was a problem hiding this comment.
Thanks for addressing it 👍
371ce6b to
e45d19f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes duplicated code from k8s reflectors module:
Summary of changes
DynamicObjectReflectorandK8sControllerReflector<K>types are unified intoReflector<K>Out of scope