Skip to content

Pass simplify flag to _jac in tangent_vector_f - #65

Merged
Wrzlprmft merged 2 commits into
neurophysik:masterfrom
alexfikl:forward-jac-simplify
Apr 6, 2026
Merged

Wrzlprmft merged 2 commits into
neurophysik:masterfrom
alexfikl:forward-jac-simplify

Conversation

@alexfikl

@alexfikl alexfikl commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

This is mostly to allow turning off the simplify for tangent vectors.

For some context: I had a big system and the code generation for the Lyapunov run was taking a lot of time. Disabling simplify here and letting the C compiler do more work seemed to help.

@alexfikl

alexfikl commented Apr 5, 2026

Copy link
Copy Markdown
Contributor Author

Hm, the CI doesn't seem to be running. I think you need to go in https://github.com/neurophysik/jitcdde/actions/workflows/ci.yml and manually re-enabled it.

Simplify the output, not the input.
@Wrzlprmft

Copy link
Copy Markdown
Contributor

This is mostly to allow turning off the simplify for tangent vectors.

For some context: I had a big system and the code generation for the Lyapunov run was taking a lot of time. Disabling simplify here and letting the C compiler do more work seemed to help.

The code was wrong anyway as it simplified the input, not the output. I changed that. As the output tends to be much more simple than the input in many scenarios, this might solve your problem without disabling simplification. Still, it’s not bad to have the flag control this.

Hm, the CI doesn't seem to be running. I think you need to go in https://github.com/neurophysik/jitcdde/actions/workflows/ci.yml and manually re-enabled it.

Indeed. It seems to have been disabled after 60 days of nothing happening on the repository. Unfortunately there seems to be no way to prevent this that is less annoying than manually re-enabling it. If at the very least it would reactivate upon a pull request or similar …

@Wrzlprmft
Wrzlprmft merged commit 5398fb1 into neurophysik:master Apr 6, 2026
7 of 8 checks passed
@alexfikl
alexfikl deleted the forward-jac-simplify branch April 6, 2026 09:06
@alexfikl

alexfikl commented Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

The code was wrong anyway as it simplified the input, not the output. I changed that. As the output tends to be much more simple than the input in many scenarios, this might solve your problem without disabling simplification.

Didn't even notice that, you're right! I'll test it again and see.

Indeed. It seems to have been disabled after 60 days of nothing happening on the repository. Unfortunately there seems to be no way to prevent this that is less annoying than manually re-enabling it. If at the very least it would reactivate upon a pull request or similar …

Yeah, completely agreed, it's not great at all :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants