Skip to content

Security Fix: response file (-@) option parsing UAF affecting debug format selection (-F / -g) #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xmoezzz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security Fix: response file (-@) option parsing UAF affecting debug format selection (-F / -g) #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions asm/nasm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ static void help(FILE *out, const char *what);

static bool using_debug_info;
static const char *debug_format;
static bool debug_format_owned;

#ifndef ABORT_ON_PANIC
# define ABORT_ON_PANIC 0
Expand Down Expand Up @@ -1066,7 +1067,10 @@ static bool process_arg(char *p, char *q, int pass)
case 'F': /* specify debug format */
if (pass == 1) {
using_debug_info = true;
debug_format = param;
if (debug_format_owned && debug_format)
nasm_free(debug_format);
debug_format = nasm_strdup(param);
debug_format_owned = true;
}
break;

Expand All @@ -1083,8 +1087,13 @@ static bool process_arg(char *p, char *q, int pass)
case 'g':
if (pass == 1) {
using_debug_info = true;
if (p[2])
debug_format = nasm_skip_spaces(p + 2);
if (p[2]) {
const char *s = nasm_skip_spaces(p + 2);
if (debug_format_owned && debug_format)
nasm_free(debug_format);
debug_format = nasm_strdup(s);
debug_format_owned = true;
}
}
break;

Expand Down