Add settings, markup and docs for track artwork lookup - #23
Open
tonyzeoli wants to merge 1 commit into
Open
Conversation
Some stream types (notably Live365) don't include album art in their metadata feed, only title/artist. Adds a "Fetch Album Artwork?" setting plus optional Spotify Client ID/Secret fields (Bar tab), a rp-now-playing-artwork image element in the player bar markup for Stream Player PRO's iTunes/Spotify lookup to populate, and matching documentation (docs/Player.md, docs/Options.md, readme.txt FAQ) explaining that Spotify fallback requires the site owner's own free Spotify Developer account. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rp-now-playing-artwork<img>element to the player bar's now-playing markup (player/radio-player.php), alongside the existing title/artist/album elements, hidden by default until populated.docs/Player.md, documents the new settings indocs/Options.md, and extends the existing "Does this plugin use any 3rd party services?" FAQ entry inreadme.txtto disclose iTunes/Spotify usage — explicit that Spotify credentials are the site owner's own responsibility to obtain.This mirrors the equivalent work just done on Radio Station / Radio Station PRO, so both product lines stay in sync. Pairs with a companion PR on stream-player-pro that does the actual iTunes/Spotify lookup and populates this element — this PR only adds the settings surface, markup hook and docs so the free plugin exposes the extension points PRO needs. No behavior change without PRO active.
Note: branched off `master`, not `develop` — `develop` in this repo is 90 commits behind and hasn't been touched since 2023, while active development clearly continues on `master`.
Test plan
🤖 Generated with Claude Code