Skip to content

Add shell approval disposition matrix #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 5 commits into from
Aug 4, 2026
Merged

Add shell approval disposition matrix #1750

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0c587f
Fix shell approval scope extraction
Aaronontheweb Aug 4, 2026
e5dd3f4
Add shell approval disposition matrix
Aaronontheweb Aug 4, 2026
a0159db
Use the Personal install policy in approval tests
Aaronontheweb Aug 4, 2026
c7b13f1
Use the host temp path in approval snapshots
Aaronontheweb Aug 4, 2026
69e5af2
Name observed shell candidate verbs precisely
Aaronontheweb Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/Netclaw.Actors.Tests/Tools/ScopedShellSafeVerbPolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// -----------------------------------------------------------------------
using Netclaw.Actors.Tools;
using Netclaw.Configuration;
using Netclaw.Security;
using Netclaw.Tools;
using Xunit;

Expand Down Expand Up @@ -59,6 +60,9 @@ private static void SafeDelete(string path)
private static SafeVerbList VerbList(params string[] verbs)
=> SafeVerbList.FromVerbs(verbs);

private static IReadOnlyList<ApprovalCandidate> Candidates(params string[] verbs)
=> verbs.Select(verb => new ApprovalCandidate(verb, Directory: null)).ToList();

private ToolInvocationContext PersonalContext(string? projectDir = null, string? sessionDir = null)
=> TestToolExecutionContext.CreateBound("session-1", sessionDir ?? _sessionDir, new TestToolExecutionContextOptions
{
Expand Down Expand Up @@ -153,7 +157,7 @@ public void All_short_circuit_returns_false_when_any_verb_is_unsafe()
var policy = new ScopedShellSafeVerbPolicy(VerbList("grep", "cat"));
var ctx = PersonalContext(projectDir: _projectDir);

Assert.False(policy.AllShortCircuit(["grep", "git push"], _projectDir, ctx));
Assert.False(policy.AllShortCircuit(Candidates("grep", "git push"), _projectDir, ctx));
}

[Fact]
Expand All @@ -162,7 +166,7 @@ public void All_short_circuit_returns_true_when_every_verb_is_safe_and_in_space(
var policy = new ScopedShellSafeVerbPolicy(VerbList("grep", "cat", "wc"));
var ctx = PersonalContext(projectDir: _projectDir);

Assert.True(policy.AllShortCircuit(["grep", "cat", "wc"], _projectDir, ctx));
Assert.True(policy.AllShortCircuit(Candidates("grep", "cat", "wc"), _projectDir, ctx));
}

[Fact]
Expand Down Expand Up @@ -206,6 +210,16 @@ public void New_safe_verb_chained_with_mutating_verb_still_prompts()
var policy = new ScopedShellSafeVerbPolicy(VerbList("date"));
var ctx = PersonalContext(projectDir: _projectDir);

Assert.False(policy.AllShortCircuit(["date", "git push origin main"], _projectDir, ctx));
Assert.False(policy.AllShortCircuit(Candidates("date", "git push origin main"), _projectDir, ctx));
}

[Fact]
public void Candidate_path_outside_safe_spaces_falls_through_to_prompt()
{
var policy = new ScopedShellSafeVerbPolicy(VerbList("cat"));
var ctx = PersonalContext(projectDir: _projectDir);
var candidates = new[] { new ApprovalCandidate("cat", _outsideDir) };

Assert.False(policy.AllShortCircuit(candidates, _projectDir, ctx));
}
}
Loading
Loading