Skip to content

Fix write_config called without description Error - #134

Open
gwaitsi wants to merge 1 commit into
netbirdio:mainfrom
gwaitsi:addedit-string
Open

gwaitsi wants to merge 1 commit into
netbirdio:mainfrom
gwaitsi:addedit-string

Conversation

@gwaitsi

@gwaitsi gwaitsi commented Oct 7, 2026 •

Copy link
Copy Markdown

When clicking the Settings - Save Button an error
"write_config called without description" appears. Fix to prevent this error

Summary by CodeRabbit

  • User Experience
    • Updated the confirmation message shown after saving NetBird settings to “NetBird settings saved.”

When clicking the Settings - Save Button an error
"write_config called without description" appears. Fix to prevent this error
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d8d6e972-a4b1-454d-ad13-7fba7d436af2
📥 Commits

Reviewing files that changed from the base of the PR and between efd90f0 and c66b4c5.

📒 Files selected for processing (1)
  • pfSense-pkg-NetBird/files/usr/local/pkg/netbird.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The NetBird package configuration now sets the save confirmation message to “NetBird settings saved.”

Changes

Save confirmation

Layer / File(s) Summary
Set save confirmation message
pfSense-pkg-NetBird/files/usr/local/pkg/netbird.xml
The package configuration adds “NetBird settings saved” as the save confirmation message.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to c66b4

The settings save now supplies the confirmation description needed by the add/edit save path. No identified issue blocks merging.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a description to prevent the “write_config called without description” error when saving NetBird settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit saw the settings save,
And heard a message, clear and brave.
“NetBird settings saved,” it read,
Then hopped along with ears ahead.
One small line now greets the day.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant