Skip to content

feat(http): make bind host configurable - #7

Open
artgas1 wants to merge 1 commit into
netbirdio:mainfrom
artgas1:feat/infra-1235-bind-host
Open

artgas1 wants to merge 1 commit into
netbirdio:mainfrom
artgas1:feat/infra-1235-bind-host

Conversation

@artgas1

@artgas1 artgas1 commented Sep 15, 2026

Copy link
Copy Markdown

Summary

  • add a HOST option for the Streamable HTTP listener
  • preserve the existing 0.0.0.0 default for container/cloud deployments
  • document and test HOST=127.0.0.1 for local-only daemons

Motivation

Local shared-daemon deployments need to restrict NetBird MCP to loopback. app.listen(port) currently binds all interfaces, which exposes the MCP endpoint to the LAN when direct-PAT auth is enabled.

QA

  • npm test — 165 passed
  • npm run typecheck
  • npm run build
  • live negative control: listener 127.0.0.1:39417; loopback /healthz 200; host LAN address refused with curl rc=7

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 119ca206-e5fc-4fdf-9eae-5b0cd4df8c7d


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@artgas1 artgas1 closed this Sep 15, 2026
@artgas1 artgas1 reopened this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant