Repository navigation
Temporary: adapt the app to the MDM-aware gomobile binding - #282
Merged
pappz merged 1 commit intoOct 7, 2026
Merged
Conversation
…ding The netbird submodule bump pulls in the mobile MDM bridge (netbirdio/netbird#6435), which changed two binding signatures the app calls: Android.newAuth now takes a PolicyFetcher, and Preferences.getPreSharedKey was replaced by hasPreSharedKey. Pass a null fetcher, which the Go side treats as MDM enforcement off, and switch the pre-shared key check to the new boolean getter. This is a temporary bridge until the Android MDM support in #278 wires the real fetcher through these call sites.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
riccardomanfrin
approved these changes
Oct 7, 2026
pappz
added a commit
that referenced
this pull request
Oct 7, 2026
* Bump netbird submodule to the deadline-only session watcher The engine no longer arms expiry-warning timers on Android and the gomobile StateChangeListener drops OnSessionExpiring; the app schedules the warnings itself from the deadline. * Keep the scheduler tests from running the worker during schedule With the SynchronousExecutor a job with zero initial delay runs inside schedule(). The tests used a deadline 5 minutes out, so the T-10 job ran immediately: it marked the warning fired and finished, which broke workerSkipsOtherProfile and cancelAllKeepsFiredMarks and let the in-window test pass on the automatic run instead of its own call. Use a deadline an hour out where the test drives the worker itself, and let the late-warning test assert on the automatic run directly. * Bump netbird submodule to main with the deadline-only session watcher * Adapt the setup-key login and PSK check to the MDM-aware gomobile binding (#282) The netbird submodule bump pulls in the mobile MDM bridge (netbirdio/netbird#6435), which changed two binding signatures the app calls: Android.newAuth now takes a PolicyFetcher, and Preferences.getPreSharedKey was replaced by hasPreSharedKey. Pass a null fetcher, which the Go side treats as MDM enforcement off, and switch the pre-shared key check to the new boolean getter. This is a temporary bridge until the Android MDM support in #278 wires the real fetcher through these call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix
This is a stop-gap so #281 compiles again. It is not the Android MDM integration; that lands in #278, which rewrites these same three lines to pass the real policy fetcher.
Problem
#281 bumps the
netbirdsubmodule from76ea72237to2b5293687. That range includes the mobile MDM bridge (netbirdio/netbird#6435), which changed two gomobile binding signatures the app calls:Android.newAuth(configPath, mgmUrl)Android.newAuth(configPath, mgmUrl, PolicyFetcher)Preferences.getPreSharedKey() : StringPreferences.hasPreSharedKey() : booleanbuild-debugfails inapp:compileDebugJavaWithJavacwith three errors, sounit-testsandinstrumented-testsnever start.