Repository navigation
fix(logging): default to info and rate-limit forged DNS logs with milestone summaries - #50
Merged
Merged
Conversation
Forged resolvers can generate huge response volumes (e.g. total forged=678341), and info-level logging floods stderr. This hides operational logs like session, stream creation, and reconnection events. Keep forged counters unchanged; only reduce log verbosity.
Replace per-response forged DNS logging with milestone-based INFO summaries (10, 100, 500, 1k, 2.5k, 5k; then 10k/50k/100k intervals). Keep forged detection and counters unchanged.
ebpfx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes two logging updates:
Default log level is now
infofor both binaries:vaydns-client/main.govaydns-server/main.goForged DNS response logging in
client/dns.gois changed from per-response output to milestone-based INFO summaries.Forged logging behavior
Forged responses are always counted, but INFO logs are emitted only when total forged reaches:
10, 100, 500, 1000, 2500, 500010,000from10,000to100,00050,000from100,000to1,000,000100,000after1,000,000Non-milestone forged responses produce no log output (including DEBUG).
Why
infolevel.Impact
Total,SERVFAIL,NXDOMAIN,Other).