Repository navigation
fix: clean worker shutdown on transport close - #47
Merged
Merged
Conversation
Expose QueuePacketConn.Closed() channel and make all transport worker goroutines (UDP, DNS, HTTP, TLS) check it instead of blocking forever on OutgoingQueue channels that are never closed by Close(). Prevents ~100+ goroutine leaks per reconnect cycle. Co-Authored-By: ebpfx <262974424+ebpfx@users.noreply.github.com>
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose
QueuePacketConn.Closed()channel and make all transport worker goroutines check it on each iteration, so they exit cleanly when the conn is closed during reconnect.for rangewithselectonclosed/outgoing, make backoff waits interruptibleclosedchecks in select branches and afterrateLimiter.Wait(), adddefer pollTimer.Stop()for rangewithselectonclosed/outgoingWithout this fix, each reconnect cycle leaks ~100+ goroutines (UDP workers + DNS/HTTP/TLS sendLoops) that block forever on OutgoingQueue channels not closed by
Close().Partially based on ideas from #41.
Test plan
go build ./.../go test ./...bash e2e/tunnel/run.sh txtbash e2e/recovery/run.shbash e2e/transport-recovery/run.sh