Fix frozen string literal support#83
Merged
Merged
Conversation
Drop EOL Ruby 2.3-2.5 from CI matrix (net-ssh 7.x requires >= 2.6).
rdoc was removed from default gems in Ruby 4.0.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| # Specify your gem's dependencies in mygem.gemspec | ||
| gemspec | ||
|
|
||
| gem "net-ssh", ">= 7.3.1" |
Collaborator
There was a problem hiding this comment.
Should the gem version be specified in net-scp.gemspec instead?
Collaborator
Author
There was a problem hiding this comment.
I think it's fine, in gem spec it would me a backward incompat change. Users can still use with older net-ssh for example if they are on ruby not supported by later net-ssh, just frozen string literals will not fully work for them.
Use mutable string (+''} for channel[:error_string] so appending error messages works with frozen_string_literal enabled.
mfazekas
changed the title
Collaborator
Author
|
This fix is now available in net-scp 4.1.1.rc3 on RubyGems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix frozen string literal compatibility and CI.
+'') forchannel[:error_string]— was raisingFrozenErrorinstead ofNet::SCP::Errorwhen appending error messagesnet-ssh >= 7.3.1in Gemfile for CI (frozen string fixes in net-ssh)