Skip to content

port: keep Codex account labels private on Windows - #491

Open
Finesssee wants to merge 1 commit into
port/upstream-0.60.0from
port/micro-0.60.0-codex-privacy
Open

port: keep Codex account labels private on Windows#491
Finesssee wants to merge 1 commit into
port/upstream-0.60.0from
port/micro-0.60.0-codex-privacy

Conversation

@Finesssee

Copy link
Copy Markdown
Collaborator

Summary

Ports upstream commit 4cfb60692bdd8cfbba7a491e94bb121b59a835a5:
fix: keep Codex account switcher labels private and distinct (#3551).

When Hide Personal Info is enabled, Codex account labels and tooltips now use stable opaque Account N values in both the React account menu and the Windows native tray menu. Privacy-off display behavior is preserved.

Scope

Included:

  • React Codex account menu privacy labels and tooltips
  • React coverage for stable account ordering and privacy-off behavior
  • Windows native tray account labels with the same privacy contract

Excluded:

  • Rust account model or schema changes
  • bridge changes
  • localization changes
  • shared abstraction extraction
  • settings redesign
  • application version changes

Validation

Passed:

  • pnpm test — 60 files, 350 tests
  • pnpm build — locale drift, TypeScript, and Vite build passed
  • pnpm --dir apps/desktop-tauri run tauri:build:debug — fresh Windows debug binary built at target/debug/codexbar-desktop-tauri.exe
  • CUA validation against that fresh binary — app launch, Advanced → Hide Personal Info toggle/read-back, restoration, and clean shutdown
  • cargo fmt --all -- --check
  • git diff --check

Notes:

  • The local environment has one configured Codex account, so the multi-account menu is intentionally not exposed in the desktop UI. Focused tests cover the two-account privacy behavior, stable opaque ordinals, tie handling, and visible-label regression.
  • The native tray Rust test was blocked before execution because the Windows MSVC target resolves link.exe to the GNU link wrapper (link: extra operand ... .o). No Rust assertion failure was observed; toolchain repair is outside this PR.

Review boundary

Please review only these three files:

  • apps/desktop-tauri/src/components/CodexAccountsMenu.tsx
  • apps/desktop-tauri/src/components/CodexAccountsMenu.test.tsx
  • apps/desktop-tauri/src-tauri/src/tray_accounts.rs

Base branch: port/upstream-0.60.0
Head branch: port/micro-0.60.0-codex-privacy

Keep this PR open and unmerged.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 7ad6b290-867a-40db-ab97-508cf00b1395

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant