port: keep Codex account labels private on Windows - #491
Open
Finesssee wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports upstream commit
4cfb60692bdd8cfbba7a491e94bb121b59a835a5:fix: keep Codex account switcher labels private and distinct (#3551).When Hide Personal Info is enabled, Codex account labels and tooltips now use stable opaque
Account Nvalues in both the React account menu and the Windows native tray menu. Privacy-off display behavior is preserved.Scope
Included:
Excluded:
Validation
Passed:
pnpm test— 60 files, 350 testspnpm build— locale drift, TypeScript, and Vite build passedpnpm --dir apps/desktop-tauri run tauri:build:debug— fresh Windows debug binary built attarget/debug/codexbar-desktop-tauri.execargo fmt --all -- --checkgit diff --checkNotes:
link.exeto the GNU link wrapper (link: extra operand ... .o). No Rust assertion failure was observed; toolchain repair is outside this PR.Review boundary
Please review only these three files:
apps/desktop-tauri/src/components/CodexAccountsMenu.tsxapps/desktop-tauri/src/components/CodexAccountsMenu.test.tsxapps/desktop-tauri/src-tauri/src/tray_accounts.rsBase branch:
port/upstream-0.60.0Head branch:
port/micro-0.60.0-codex-privacyKeep this PR open and unmerged.