Skip to content

Port v0.57.0: harden OpenCodex numeric and cache parsing - #489

Open
Finesssee wants to merge 1 commit into
port/micro-0.57.0-codex-whitespacefrom
port/micro-0.57.0-opencodex-numeric
Open

Port v0.57.0: harden OpenCodex numeric and cache parsing#489
Finesssee wants to merge 1 commit into
port/micro-0.57.0-codex-whitespacefrom
port/micro-0.57.0-opencodex-numeric

Conversation

@Finesssee

@Finesssee Finesssee commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

What changed

Ports upstream v0.57.0 commit b1e27d266a8e1a0db991be7cf40526f12e6a4e1d (fix: reject unrepresentable numeric usage safely (#3486)) into the Windows OpenCodex spend path.

  • Rejects the rounded floating-point 2^64 boundary before the u64 cast while preserving exact JSON integer u64::MAX.
  • Adds parser version 1 to the OpenCodex parse cursor and forces a full reparse for missing or mismatched versions.
  • Keeps CACHE_SCHEMA_VERSION = 2; this is parser compatibility gating, not a cache container format change.

Scope

  • rust/src/spend_contract/opencodex.rs
  • rust/src/spend_contract/opencodex/cache.rs

This is a stacked micro-PR after #488, with base branch port/micro-0.57.0-codex-whitespace. It does not change the app version, release files, CI, or later upstream versions.

Validation

  • cargo fmt --all -- --check — passed
  • git diff --check — passed
  • Focused Rust test and cargo check --manifest-path rust/Cargo.toml --tests — attempted, but blocked before test execution because this host has no MSVC cl.exe; where.exe resolves Git's usr/bin/link.exe, so rustc fails in linking.
  • Oracle review — approved the numeric boundary, parser-version migration, test coverage, PR scope, and published stack.

Upstream reference

  • Commit: b1e27d266a8e1a0db991be7cf40526f12e6a4e1d
  • Release range: v0.56.8...v0.57.0

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0207b0d1-037a-47f4-a489-3d8a5766b5b5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant