docs: document Ollama/MiniMax fixes and Codex OAuth staleness gate - #432
Closed
leoarayas wants to merge 4 commits into
Closed
docs: document Ollama/MiniMax fixes and Codex OAuth staleness gate#432leoarayas wants to merge 4 commits into
leoarayas wants to merge 4 commits into
Conversation
Auto/Web cookie import stopped at the first installed browser that returned any cookies for ollama.com, even when those cookies were stale/irrelevant (e.g. a consent or analytics cookie left over from a one-off visit) and carried no recognized session cookie. That starved out a later browser (often the one actually signed in) and surfaced "No cookies available for web API" even with a valid, logged-in session sitting on disk. Walk every detected browser and keep going until one yields a header containing a recognized Ollama session cookie, instead of stopping at the first non-empty result. Extracted the selection logic into a small pure helper with a focused regression test reproducing the exact scenario (irrelevant-only cookies on one browser, real session on the next). Fixes nesszer#426 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L23pzyCfMvfbMQwnHXmKCp
MiniMax redesigned the console: /console/usage and /console/plan are now client-rendered Next.js pages loaded with `ssr:false`, so the server never emits real numbers in the initial HTML — not even with a valid, authenticated cookie. Every cookie/HTML-scraping path is structurally unable to read this data, so MiniMax usage fell through to the always-0% "configured" stub whenever cookie scraping failed. The coding-plan `remains` endpoint the HTML scraper already falls back to also accepts a plain `Authorization: Bearer <api_key>` with no cookie at all, and returns the exact `model_remains` JSON shape the existing parser (coding_plan.rs) already understands. Add a Bearer-authenticated path that tries this endpoint first, using an API key from Settings or `MINIMAX_API_KEY`, before falling back to the legacy group_id+api_key billing endpoint. Also register MiniMax in `get_api_key_providers()` so the API key can be entered through Settings/`config set-api-key` like other providers — previously there was no supported way to configure just an API key (only a paired group_id+api_key via env vars or a local `minimax`-CLI-style config file). Fixes nesszer#425 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L23pzyCfMvfbMQwnHXmKCp
Covers three issues investigated and fixed/diagnosed in this session: - Ollama browser-priority cookie starvation (fixed, PR nesszer#430) - MiniMax client-rendered console pages / Bearer API key fix (fixed, PR nesszer#431) - Codex external-OAuth staleness gate (working as designed, undocumented until now — symptom looks like a bug but the fix is refreshing the Codex CLI's own session, not a CodexBar change) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L23pzyCfMvfbMQwnHXmKCp
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe change adds MiniMax API-key usage retrieval and configuration, updates Ollama browser cookie scanning, and documents MiniMax, Ollama, and Codex authentication behavior. ChangesProvider fixes
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant FetchContext
participant MiniMaxUsage
participant MiniMaxAPI
participant LegacyBilling
FetchContext->>MiniMaxUsage: Provide configured API key
MiniMaxUsage->>MiniMaxAPI: Request remains with Bearer key
MiniMaxAPI-->>MiniMaxUsage: Return usage or endpoint status
MiniMaxUsage->>LegacyBilling: Use paired credentials when needed
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment Warning |
Author
|
Closing — this was internal documentation for our own repo copy, not meant for upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation-only PR. Adds three short sections to
docs/PROVIDERS.mdcovering issues investigated and fixed/diagnosed in this pass:auth.json) looks like a bug; the actual fix is refreshing the Codex CLI's own session (codex doctor/ any network-touching Codex CLI use), not a CodexBar change. Worth a paper trail so it isn't re-investigated as a bug next time.No code changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_01L23pzyCfMvfbMQwnHXmKCp
Summary by CodeRabbit
Bug Fixes
Configuration
Documentation