Skip to content

fix: skip buffers with URI schemes in root_dir #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niklaas wants to merge 4 commits into
base: master
Choose a base branch
from
+12 −0
Open

fix: skip buffers with URI schemes in root_dir #4345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39b9240
fix(ts_ls): skip buffers with URI schemes in root_dir
niklaas Mar 14, 2026
848079b
fix(tsgo): skip buffers with URI schemes in root_dir
niklaas Mar 14, 2026
257c9cf
fix(vtsls): skip buffers with URI schemes in root_dir
niklaas Mar 14, 2026
c1f4b9e
fix(matlab_ls): skip buffers with URI schemes in root_dir
niklaas Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lsp/matlab_ls.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ return {
cmd = { 'matlab-language-server', '--stdio' },
filetypes = { 'matlab' },
root_dir = function(bufnr, on_dir)
if vim.api.nvim_buf_get_name(bufnr):match('^%a+://') then
return
end
local root_dir = vim.fs.root(bufnr, '.git')
on_dir(root_dir or vim.fn.getcwd())
Comment on lines +23 to 27
Copy link
Copy Markdown
Member

@justinmk justinmk Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clear explanation. But I don't quite see why the solution was chosen.

I think it's more like a hint that getcwd() should not be used as a fallback. People really seem to love it though ...

Copy link
Copy Markdown
Author

@niklaas niklaas Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more like a hint that getcwd() should not be used as a fallback.

Good catch, I agree. I guess I subconsciously decided to use a guard to avoid introducing a breaking change.

However, I'm happy to remove calling getcwd(). As you indicate, arguably, the issue I ran into demonstrates the function isn't the proper approach to choose there because it's brittle.

Let me know if you'd be willing to introduce a breaking change.

end,
Expand Down
3 changes: 3 additions & 0 deletions lsp/ts_ls.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ return {
'typescriptreact',
},
root_dir = function(bufnr, on_dir)
if vim.api.nvim_buf_get_name(bufnr):match('^%a+://') then
return
end
-- The project root is where the LSP can be started from
-- As stated in the documentation above, this LSP supports monorepos and simple projects.
-- We select then from the project root, which is identified by the presence of a package
Expand Down
3 changes: 3 additions & 0 deletions lsp/tsgo.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ return {
'typescriptreact',
},
root_dir = function(bufnr, on_dir)
if vim.api.nvim_buf_get_name(bufnr):match('^%a+://') then
return
end
-- The project root is where the LSP can be started from
-- As stated in the documentation above, this LSP supports monorepos and simple projects.
-- We select then from the project root, which is identified by the presence of a package
Expand Down
3 changes: 3 additions & 0 deletions lsp/vtsls.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ return {
'typescriptreact',
},
root_dir = function(bufnr, on_dir)
if vim.api.nvim_buf_get_name(bufnr):match('^%a+://') then
return
end
-- The project root is where the LSP can be started from
-- As stated in the documentation above, this LSP supports monorepos and simple projects.
-- We select then from the project root, which is identified by the presence of a package
Expand Down
Loading