Fix: The start should be the inclusive max key if Backward scan#1084
Open
Wi1l-B0t wants to merge 1 commit into
Open
Fix: The start should be the inclusive max key if Backward scan#1084Wi1l-B0t wants to merge 1 commit into
start should be the inclusive max key if Backward scan#1084Wi1l-B0t wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1084 +/- ##
=========================================
Coverage ? 47.32%
=========================================
Files ? 273
Lines ? 15779
Branches ? 2017
=========================================
Hits ? 7467
Misses ? 7799
Partials ? 513 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ajara87
reviewed
Jul 4, 2026
AnnaShaleva
reviewed
Jul 9, 2026
AnnaShaleva
left a comment
AnnaShaleva
left a comment
Member
There was a problem hiding this comment.
This will change the existing behaviour of interops like System.Storage.Find and some other core functionality dependent from the Store.
Contributor
Author
The current implementation is wrong, and this method is not used by Only the N4 has this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
startshould be the inclusive max key ifBackwardscan, and the inclusive min key ifForwardscan.The current implementation treats the
startas the min key ifBackwardscan.