util.c: include poll.h instead of sys/poll.h#20
Open
maxinbjohn wants to merge 3 commits intoneilbrown:masterfrom
Open
util.c: include poll.h instead of sys/poll.h#20maxinbjohn wants to merge 3 commits intoneilbrown:masterfrom
maxinbjohn wants to merge 3 commits intoneilbrown:masterfrom
Conversation
This fixes a compile warning when building with musl: In file included from util.c:27:0: | qemux86-64/usr/include/sys/poll.h:1:2: error: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Werror=cpp] | #warning redirecting incorrect #include <sys/poll.h> to <poll.h> | ^ Signed-off-by: Maxin B. John <maxin.john@intel.com>
Fixes this build error: | In file included from mdadm.c:28:0: | mdadm.h:142:0: error: "bswap_16" redefined [-Werror] | #define bswap_16(x) (((x) & 0x00ffU) << 8 | \ | ^ Signed-off-by: Maxin B. John <maxin.john@intel.com>
With x32 toolchain, this code caused the below listed error: | Monitor.c: In function 'check_array': | Monitor.c:545:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] | if (st->utime == array.utime && Signed-off-by: Maxin B. John <maxin.john@intel.com>
|
Neil isn't maintainer of the mdadm from February. And as I understand all PR or issues should be send via email to dm-devel@redhat.com or linux-raid@vger.kernel.org. @neilbrown, I think you should change description of this repo according to actual mdadm maintainer. |
Author
|
@Alukardd Thanks for the info. I will send these patches to linux-raid@vger.kernel.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a compile warning when building with musl:
In file included from util.c:27:0:
|
qemux86-64/usr/include/sys/poll.h:1:2:
error: #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
[-Werror=cpp]
| #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
| ^
Signed-off-by: Maxin B. John maxin.john@intel.com