test: use backwards_compatible_rs_contract where appropriate#9175
Merged
near-bulldozer[bot] merged 5 commits intonear:masterfrom Jun 12, 2023
Merged
test: use backwards_compatible_rs_contract where appropriate#9175near-bulldozer[bot] merged 5 commits intonear:masterfrom
backwards_compatible_rs_contract where appropriate#9175near-bulldozer[bot] merged 5 commits intonear:masterfrom
Conversation
`rs_contract` can be used by tests that run only on the latest protocol version, as defined by the const PROTOCOL_VERSION. `base_rs_contract` must be used in backwards compatibility tests that rely on specific protocol versions. This is a pre-requisite to land the rustc 1.70 toolchain upgrade. (See also near#9140)
Merged
nagisa
approved these changes
Jun 12, 2023
Contributor
|
Would be great to rename base_rs_contract to something that describes its properties in a more straightforward way. Right now "base" says approximately nothing about what this contract is. |
to `backwards_compatible_rs_contract`
Contributor
Author
very true, renamed to |
jakmeier
changed the title
base_rs_contract where appropriatebackwards_compatible_rs_contract where appropriate
nikurt
pushed a commit
that referenced
this pull request
Jun 13, 2023
`rs_contract` can be used by tests that run only on the latest protocol version, as defined by the const PROTOCOL_VERSION. `backwards_compatible_rs_contract` must be used in backwards compatibility tests that rely on specific protocol versions. This is a pre-requisite to land the rustc 1.70 toolchain upgrade. (See also #9140)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rs_contractcan be used by tests that run only on the latestprotocol version, as defined by the const PROTOCOL_VERSION.
backwards_compatible_rs_contractmust be used in backwardscompatibility tests that rely on specific protocol versions.
This is a pre-requisite to land the rustc 1.70 toolchain upgrade.
(See also #9140)