refactor: governance dto compat - #4000
Draft
SimonRastikian wants to merge 8 commits into
Draft
Conversation
- Rename test `validate_threshold__should_not_produce_empty_window_for_small_n` -> `validate_governance_threshold__should_...` so the system-under-test prefix matches the renamed function. - Update the stale `validate_threshold` references in docs/design/domain-separation.md to `validate_domain_reconstruction_threshold`: in that doc `validate_threshold` validates a key's reconstruction threshold, so it maps to the reconstruction validator, not the governance one. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rename the Threshold/ThresholdParameters type family to the Governance* family across all crates (except threshold-signatures). Type-name-only change; serde uses field names and borsh is positional, so no wire change. Regenerates borsh + ABI schema snapshots (definition names + alphabetical order only; field names unchanged). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
The TODO(XXXX) will be added once the PR is validated |
SimonRastikian
marked this pull request as draft
July 29, 2026 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes partly #3903.
This PR introduces the governance threshold terminology in the smart contract. This implied changing the smart contract which could affect migration. Thus we introduced Compat structs