test(contract): sandbox coverage + stub verifier for async attestation by pbeza · Pull Request #3715 · near/mpc

pbeza · 2026-06-30T17:17:18Z

Second half of the #3664 split, stacked on #3714 (async attestation). Tests only; no production-code changes.

pbeza · 2026-07-10T15:09:46Z

Requirement carried over from review of #3714 (discussion_r3558779901):

Add sandbox coverage for the TLS-key-ownership authorization guard in store_verified_attestation (crates/contract/src/tee/tee_state.rs): a submission whose tls_public_key is already registered to a different account_id must be rejected with TlsKeyOwnedByOtherAccount, and the existing stored attestation must be left unchanged. This is a pre-existing check with no direct test today; #3715 is the right place for it since it owns the async-attestation sandbox coverage and stub verifier.

pbeza · 2026-07-10T15:43:17Z

Note-to-self / tracking from #3714 (#3714 (comment)): the async-attestation gas constants in `crates/contract/src/config.rs` are not benchmarked — `DEFAULT_VERIFIER_TERA_GAS = 100` and `DEFAULT_RESOLVE_VERIFICATION_TERA_GAS = 60` are conservative estimates. I deferred measuring them to this PR since it adds the stub-verifier sandbox coverage.

Proposal: in the `StubResponse::Verified` sandbox test, read the `resolve_verification` receipt's `total_gas_burnt` (per-receipt, via `ExecutionFinalResult::receipt_outcomes()`, same approach as `participants_gas.rs`) and size `resolve_verification_tera_gas` at ~2x the observed burn. Analytically it looks over-provisioned — the post-DCAP work is the same weight class as `clean_tee_status`/`clean_invalid_attestations` (10 Tgas), so ~20 is likely the right ceiling.

Two caveats:

`verifier_tera_gas = 100` can't be validated with the stub (it's cheap) — the real cost is the verifier's `dcap-qvl` run, which needs its own benchmark.
This measurement is only meaningful once this branch is rebased onto the post-refactor: alternative without yield resume #3766 (no-yield) `resolve_verification`; the current branch still has the yield-resume version.

If it's not trivial here, fine to spin off a follow-up issue (relatedly, other unbenchmarked constants exist, e.g. `VOTE_FOREIGN_CHAIN_GAS` in the e2e tests — #3641 discussion_r3543560094).

claude · 2026-07-13T11:58:39Z

PR title type suggestion: This PR modifies source code in src/ directories, so the type prefix should probably be feat: instead of test:.

Suggested title: feat(contract): add sandbox coverage and stub verifier for async attestation

pbeza · 2026-07-13T12:07:01Z

JFYI, I created a follow-up issue #3787 for these two comments, since they’re both blocked on the same missing fixture:

test(contract): sandbox coverage + stub verifier for async attestation #3715 (comment)
test(contract): sandbox coverage + stub verifier for async attestation #3715 (comment)

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.

pbeza · 2026-07-18T10:51:54Z

@kevindeforth @gilcu3 @netrome, I’ve addressed all the nits. Feel free to take another look.

Sorry for the force-pushes. The base PR, #3714, tends to run into conflicts with main, so I need to regularly merge origin/main into it and then rebase this PR on top. I could also merge 3642-async-attestation-core into 3642-async-attestation-tests instead, if you’d prefer. Let me know.

Hopefully, we can merge everything into main early next week once this is approved and the verifier contract is deployed.

kevindeforth

Thank you!

gilcu3

Thank you!

gilcu3 · 2026-07-20T10:28:51Z

+
+        // Then
+        // assert_matches! requires Debug, which PromiseOrValue doesn't implement
+        assert!(matches!(result, PromiseOrValue::Promise(_)));


nit: we generally prefer assert_matches

gilcu3 · 2026-07-20T10:50:30Z

 #[expect(clippy::large_enum_variant)]
-#[derive(Debug, Default, Clone, Serialize, Deserialize, BorshDeserialize, BorshSerialize)]
+#[derive(
+    Debug, Default, Clone, PartialEq, Eq, Serialize, Deserialize, BorshDeserialize, BorshSerialize,
+)]
 #[cfg_attr(


I saw this comment saying some traits were removed, but here I still see 2 included. Were this needed then?

barakeinav1

added a few comments

barakeinav1 · 2026-07-21T16:11:02Z

+    let dtos::Attestation::Dstack(dstack) = &mut attestation else {
+        panic!("fixture must be a Dstack attestation");
+    };
+    dstack.quote = dtos::HexVec(vec![0u8; 16]);


This is where the real-DCAP gas cost slips through: the quote here is 16 zero bytes, which dcap_qvl rejects at parse, so verify_quote returns almost immediately and costs next to nothing. A valid quote runs the full verification (sig + cert chain + TCB), which is far heavier — and in an e2e run on a real TDX cluster that path blows past the verifier_tera_gas = 100 default (see #3714), so attestation never completes.

Since no test here feeds a valid quote, the gas budget isn't actually covered. Might be worth a case with a real quote fixture at production gas, asserting a stored attestation.

@pbeza for reference, there's already a test that runs a real valid quote through verify_quote and gets Verified: crates/tee-verifier/tests/verify_quote.rs::verify_quote__should_return_verified_td10_report_for_valid_fixture. It uses the real test_utils::attestation::quote() + collateral() fixtures and pins the VM block timestamp to VALID_ATTESTATION_TIMESTAMP so the collateral is in its validity window.

That's the fixture setup this sandbox coverage could borrow to drive the full DCAP path (and its real gas cost) instead of the 16-byte quote that's rejected at parse. One catch is the clock: that test pins it via testing_env!; in a near-workspaces sandbox you'd need the block time inside the fixture's window (time fast-forward) for it to verify rather than expire.

@pbeza I opened a follow-up issue.
#3897

barakeinav1

need to add a test that check the real gas used by the contract (since this just failed in an E2E test).
see #3715 (comment)

…o 3642-async-attestation-tests # Conflicts: # crates/tee-context/Cargo.toml

claude · 2026-07-22T12:44:19Z

PR title type suggestion: This PR modifies source code files in addition to test files. When source code changes alongside test changes, the type should typically be something other than test:. Consider chore: since the primary intent appears to be test infrastructure/maintenance work.

Suggested title: chore(contract): add sandbox coverage + stub verifier for async attestation

…o 3642-async-attestation-tests # Conflicts: # crates/tee-context/Cargo.toml

barakeinav1

I opened a follow-up issue.
#3897

claude · 2026-07-22T13:08:05Z

PR title type suggestion: Since source code files are modified (e.g., crates/contract/src/, crates/mpc-attestation/src/), the type should probably be feat: or refactor: instead of test:.
Suggested title: feat(contract): sandbox coverage + stub verifier for async attestation

kevindeforth

Thank you!

Copilot AI review requested due to automatic review settings June 30, 2026 17:17

Copilot started reviewing on behalf of pbeza June 30, 2026 17:17 View session

This comment was marked as outdated.

Sign in to view

pbeza mentioned this pull request Jun 30, 2026

feat(contract): async TEE attestation verification via verifier contract, drop dcap-qvl #3664

Closed

This comment was marked as outdated.

Sign in to view

pbeza force-pushed the 3642-async-attestation-tests branch from 0e60532 to 47655a4 Compare July 1, 2026 11:01

This comment was marked as outdated.

Sign in to view

pbeza mentioned this pull request Jul 1, 2026

feat(contract): async TEE attestation verification, drop dcap-qvl #3714

Merged

pbeza force-pushed the 3642-async-attestation-tests branch from 98a7a50 to d3ecae2 Compare July 2, 2026 10:44

pbeza mentioned this pull request Jul 6, 2026

Add sandbox coverage and a stub verifier for async TEE attestation #3738

Open

2 tasks

pbeza force-pushed the 3642-async-attestation-tests branch from bc1f255 to 7134f67 Compare July 13, 2026 10:00

near deleted a comment from claude Bot Jul 13, 2026

pbeza mentioned this pull request Jul 13, 2026

test(contract): exercise the Verified attestation store end-to-end in sandbox (fixture account key + measurements helper) #3787

Open

5 tasks

pbeza force-pushed the 3642-async-attestation-tests branch 2 times, most recently from 54d794f to c3ab60b Compare July 14, 2026 14:01

near deleted a comment from claude Bot Jul 14, 2026

pbeza requested a review from Copilot July 14, 2026 14:39

Copilot started reviewing on behalf of pbeza July 14, 2026 14:40 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread docs/localnet/tee-localnet.md Outdated

near deleted a comment from claude Bot Jul 14, 2026

pbeza requested a review from Copilot July 14, 2026 17:09

Copilot started reviewing on behalf of pbeza July 14, 2026 17:09 View session

pbeza force-pushed the 3642-async-attestation-tests branch from 6afae04 to b21cc1e Compare July 18, 2026 10:51

near deleted a comment from claude Bot Jul 18, 2026

pbeza requested review from gilcu3 and kevindeforth July 18, 2026 12:25

kevindeforth approved these changes Jul 20, 2026

View reviewed changes

gilcu3 approved these changes Jul 20, 2026

View reviewed changes

barakeinav1 reviewed Jul 21, 2026

View reviewed changes

barakeinav1 suggested changes Jul 21, 2026

View reviewed changes

This was referenced Jul 21, 2026

update Localnet TEE cluster scripts to cover the tee-verifier contract #3887

Closed

test(localnet): deploy + vote the tee-verifier in the cluster script #3888

Closed

Move TEE cluster deploy/test scripts from mpc to mpc-private #3894

Closed

Merge remote-tracking branch 'origin/3642-async-attestation-core' int…

df67ec5

…o 3642-async-attestation-tests # Conflicts: # crates/tee-context/Cargo.toml

barakeinav1 mentioned this pull request Jul 22, 2026

Add a gas-metered sandbox test for verify_quote with a valid quote (cover the verifier_tera_gas budget) #3897

Open

2 tasks

Merge remote-tracking branch 'origin/3642-async-attestation-core' int…

de64407

…o 3642-async-attestation-tests # Conflicts: # crates/tee-context/Cargo.toml

barakeinav1 approved these changes Jul 22, 2026

View reviewed changes

pbeza requested review from gilcu3 and kevindeforth July 22, 2026 13:06

gilcu3 approved these changes Jul 22, 2026

View reviewed changes

kevindeforth approved these changes Jul 22, 2026

View reviewed changes

pbeza merged commit 28f9b90 into 3642-async-attestation-core Jul 22, 2026
15 checks passed

pbeza deleted the 3642-async-attestation-tests branch July 22, 2026 13:19

Uh oh!

Conversation

pbeza commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

pbeza commented Jul 10, 2026

Uh oh!

pbeza commented Jul 10, 2026

Uh oh!

claude Bot commented Jul 13, 2026

Uh oh!

pbeza commented Jul 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

pbeza commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevindeforth left a comment

Choose a reason for hiding this comment

Uh oh!

gilcu3 left a comment

Choose a reason for hiding this comment

Uh oh!

gilcu3 Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

gilcu3 Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

barakeinav1 left a comment

Choose a reason for hiding this comment

Uh oh!

barakeinav1 Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

barakeinav1 Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

barakeinav1 Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barakeinav1 left a comment

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Jul 22, 2026

Uh oh!

barakeinav1 left a comment

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Jul 22, 2026

Uh oh!

kevindeforth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pbeza commented Jun 30, 2026 •

edited

Loading

pbeza commented Jul 18, 2026 •

edited

Loading

barakeinav1 Jul 22, 2026 •

edited

Loading