-
Notifications
You must be signed in to change notification settings - Fork 37
feat(contract): auto-expire unused launcher image hashes #3564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
99f6904
feat(contract): auto-expire unused launcher image hashes
barakeinav1 d7c0c65
fix(contract): validate config TTL on init, dedup dummy_config value
barakeinav1 a8694aa
docs(contract): clarify overflow, re-vote, and capability-token behavior
barakeinav1 cb955fb
docs: correct attestation validity window (1 day, not 7) in comments …
barakeinav1 074a701
Merge branch 'main' into feat/auto-remove-launcher-hashes
barakeinav1 c435dc5
refactor(contract): collapse launcher timestamps to single last_used;…
barakeinav1 9759f11
style: rustfmt the enlarging_ttl test
barakeinav1 d329413
refactor(contract): add_or_refresh returns AddOutcome; sync design do…
barakeinav1 13fbc1f
Merge branch 'main' into feat/auto-remove-launcher-hashes
barakeinav1 6e3039e
docs(contract): compact refresh-on-use comment; TODO for 3.13.0 migra…
barakeinav1 096dfb1
docs(contract): drop broken public->private intra-doc link on AddOutcome
barakeinav1 d725003
Merge branch 'main' into feat/auto-remove-launcher-hashes
barakeinav1 e80673a
Merge remote-tracking branch 'origin/main' into feat/auto-remove-laun…
barakeinav1 07de77b
refactor(contract): address review nits on launcher image handling
barakeinav1 2aa024e
refactor(contract): log on is_expired overflow; fix stale 'added' tes…
barakeinav1 c95e32d
docs(contract): drop public->private intra-doc link on AllowedLaunche…
barakeinav1 e1d8955
Merge branch 'main' into feat/auto-remove-launcher-hashes
barakeinav1 04254ac
Merge remote-tracking branch 'origin/main' into feat/auto-remove-laun…
barakeinav1 37c0218
docs(contract): drop/shorten comments that restate the code
barakeinav1 eb593e5
test: add add_participant_no_expiry helper; trim two more comments
barakeinav1 df57fd8
Merge remote-tracking branch 'origin/main' into feat/auto-remove-laun…
barakeinav1 4485904
fix(contract): apply launcher expiry + refresh to WithConstraints mocks
barakeinav1 3fc93c7
Merge remote-tracking branch 'origin/main' into feat/auto-remove-laun…
barakeinav1 883dfad
Address claude[bot] review: docs, tests, and small cleanups
barakeinav1 797407a
test: add assert_matches exemption comments for PromiseOrValue
barakeinav1 6ffd125
test: mock-path participant gate — non-participant submission does no…
barakeinav1 1748925
Merge remote-tracking branch 'origin/main' into feat/auto-remove-laun…
barakeinav1 02a05c3
refactor(contract): store launcher expires_at; address review comments
barakeinav1 503a627
test(migration): cover the combined 3.13.0 migration path
barakeinav1 9cf1bd1
docs(design): update design doc to the expires_at model
barakeinav1 8591a21
refactor(contract): address review nits (error type, var placement, n…
barakeinav1 9605e6e
test(contract): add Given/When/Then to init TTL-rejection test
barakeinav1 446de39
Merge branch 'main' into feat/auto-remove-launcher-hashes
barakeinav1 791b06d
Merge remote-tracking branch 'origin/main' into feat/auto-remove-laun…
barakeinav1 a657110
refactor(contract): evict expired launcher hashes inline, drop the pr…
barakeinav1 a74258b
test(contract): cover inline launcher eviction via reverify_and_clean…
barakeinav1 87b6bc9
docs(contract): document eviction in reverify_and_cleanup_participant…
barakeinav1 94a5fc5
fix(contract): validate config at propose time
barakeinav1 ef6386d
test(contract): naming convention + real launcher migration coverage
barakeinav1 118fbee
docs(contract): clarify launcher TTL is not retroactive; link auto-ex…
barakeinav1 bf0148d
docs(contract): clarify eviction timing wording (Copilot review)
barakeinav1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am slightly concerned about us losing the capability of observing the expired hashes. Do we have any other way of doing so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point — filed #4047 to expose the launcher hashes' expiry off-chain (mirroring what
allowed_docker_image_hashes()already does), since it's a small API decision rather than in-scope here.