Repository navigation
update structure arg .Names to names for R-devel - #96
Conversation
|
Heh, thanks for getting to this before I could finish (#95). Since I already had an R-devel test environment set up, I pulled your branch to test. Can confirm there are no deprecation warnings anymore. But I do see: I see that's already set to skip on CI, so maybe that's not an issue. |
|
Ha, didn't realize CRAN did the nastygrams on a rolling schedule like that (crunch had until July 25th). Thanks for checking! |
|
Thank you for this! I have fixed CI on |
c7f93ea to
d5add84
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
===========================================
- Coverage 100.00% 98.03% -1.97%
===========================================
Files 18 18
Lines 508 508
===========================================
- Hits 508 498 -10
- Misses 0 10 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Now that CRAN is back from summer vacation, will it be possible to submit a new release soon? I can work around the issue for my package by submitting a release that skips the affected tests, but it'd be good to know either way so I can prep that if I have to. They gave me until Aug 21, although maybe they'd give leeway if they know the issue is fixed and incoming to CRAN. |
|
Thanks for the reminder, I'll try to get submitted in the next day now that they're open again. |
|
Release is up on CRAN now. Thanks for your help with this. |
|
Thanks! CRAN ran a check run on my package this morning and it seems to have passed, so the fix worked. |
Happy Summer!
This PR fixes the CRAN notes about r-devel's upcoming deprecations to
structure(.Names =...). It snuck up on me for rcrunch, so wanted to help upstream. I've skipped a few tests that are failing in rcrunch becauseexpect_silent()is catching warnings fromhttptestfor this.Thanks!