Add Pre and Post execution hooks on the step executor level#225
Open
OlfaKaroui wants to merge 1 commit into
Open
Add Pre and Post execution hooks on the step executor level#225OlfaKaroui wants to merge 1 commit into
OlfaKaroui wants to merge 1 commit into
Conversation
Member
|
Hey @OlfaKaroui! Sorry for missing your PR here for so very long. I only noticed from recent PRs opening briefly and closing (?) that this one was here. It looks like the hooks you proposed are pretty similar to the role of the Executor. Could a custom executor achieve the same result for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I added this functionality to enable some customization is specific cases. In our cases, we are trying to split a service, and to enable that we needed to have pre-execution hooks on the Step level to allow for the execution of intermediate operation during the migration.
I decided to make this into a proper PR, if you have any questions or changes requested please let me know