Change default format from ply to obj - #18
Closed
JiajunZhang-neu wants to merge 1 commit into
Closed
Conversation
Reading .ply files depends on the Rvcg package, which is not installed by default with bancr; if missing, functions may return an empty neuronlist without throwing an error. In contrast, reading .obj files does not require Rvcg, making it a more robust default workflow.
Collaborator
|
Thanks @JiajunZhang-neu — landed your fix directly in fafb442 along with an explicit |
Contributor
|
Obj files are quite a bit heavier than ply - I would have standardised on ply myself. You can just suggest Rvcg if you want. I don't know how you're reading obj but the reader in rgl is a bit flaky and the readobj package is also an external dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #17
Reading .ply files depends on the Rvcg package, which is not installed by default with bancr; if missing, functions may return an empty neuronlist without throwing an error. In contrast, reading .obj files does not require Rvcg, making it a more robust default workflow.