Skip to content

React - Handle dynamically added pane #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeevasusej wants to merge 2 commits into
base: master
Choose a base branch
from
Open

React - Handle dynamically added pane #769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0aaec7e
Handle dynamically added pane
jeevasusej Dec 1, 2022
cdfaefb
Re create for dynamically added pane
jeevasusej Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions packages/react-split/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,44 @@ class SplitWrapper extends React.Component {
} else {
needsRecreate = needsRecreate || minSize !== prevMinSize
}


let dynamicallyAdded = false;
if (
!needsRecreate &&
prevSizes &&
this.props.sizes &&
prevSizes.length != this.props.sizes.length
) {
needsRecreate = true;
dynamicallyAdded = true;
}
// Destroy and re-create split if options changed
if (needsRecreate) {
options.minSize = minSize
options.sizes = sizes || this.split.getSizes()
this.split.destroy(true, true)
options.gutter = (index, direction, pairB) => pairB.previousSibling
if(!dynamicallyAdded){
this.split.destroy(true, true);
options.gutter = (index, direction, pairB) => pairB.previousSibling
}
else{
this.split.destroy();
options.gutter = (index, direction) => {
let gutterElement

if (gutter) {
gutterElement = gutter(index, direction)
} else {
gutterElement = document.createElement('div')
gutterElement.className = `gutter gutter-${direction}`
}

// eslint-disable-next-line no-underscore-dangle
gutterElement.__isSplitGutter = true
return gutterElement
}
}


this.split = Split(
Array.from(this.parent.children).filter(
// eslint-disable-next-line no-underscore-dangle
Expand Down