fix: resolve relative discovery redirects against the request URL - #281
Merged
natelindev merged 1 commit intoSep 30, 2026
Merged
Conversation
|
@bensynapse is attempting to deploy a commit to the llldar's projects Team on Vercel. A member of the Team first needs to authorize it. |
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Discovery resolves relative
Locationheaders againstserverUrl, even though the request goes to/.well-known/caldavor/.well-known/carddav.For
serverUrl=https://example.com/calendars/user1/, aLocation: ../dav/response incorrectly produces/calendars/dav/instead of/dav/.Resolve redirects against the discovery request URL. This follows RFC 9110.
The regressions cover relative paths and query strings through PROPFIND and GET fallback. Both client APIs have regressions.
All eight new cases fail before the fix.
Validated on Node 22 with
pnpm test(306 tests),pnpm typecheck,pnpm lintandpnpm build.Live provider tests were not run.