Skip to content

Cannot depend on itself for installation - #51

Merged
brisvag merged 4 commits into
napari:mainfrom
brisvag:fix/generation-not-installed
Aug 28, 2026
Merged

Cannot depend on itself for installation#51
brisvag merged 4 commits into
napari:mainfrom
brisvag:fix/generation-not-installed

Conversation

@brisvag

@brisvag brisvag commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

See error at https://github.com/napari/resources/actions/runs/33185435504/job/98897109030#step:3:278

We cannot depend on the package being available/installed while we are packaging it. This means calls to resources are not doable during the hook, so we need to update the code to allow manually passing in the lists of variants. A bit uglier, but I guess it's ok.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.72%. Comparing base (0e2bb3d) to head (9e56fa0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/napari_resources/generate_logos.py 73.91% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   42.92%   43.72%   +0.79%     
==========================================
  Files           3        3              
  Lines         205      215      +10     
==========================================
+ Hits           88       94       +6     
- Misses        117      121       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brisvag
brisvag merged commit 2e1264d into napari:main Aug 28, 2026
14 checks passed
@brisvag
brisvag deleted the fix/generation-not-installed branch August 28, 2026 16:13
@brisvag brisvag mentioned this pull request Aug 28, 2026
brisvag added a commit that referenced this pull request Aug 28, 2026
Forgot to add the paths to the hook after #51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant