Skip to content

aarch64: Fix context refcount leak on SVC dispatch #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertream wants to merge 1 commit into
base: master
Choose a base branch
from
Open

aarch64: Fix context refcount leak on SVC dispatch #2171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aarch64/interrupt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,10 @@ void synchronous_handler(void)
int ec = field_from_u64(esr, ESR_EC);
if (ec == ESR_EC_SVC_AARCH64 && (esr & ESR_IL) &&
field_from_u64(esr, ESR_ISS_IMM16) == 0) {
/* The fault path releases the reserve above via the fault_handler
return; the SVC path dispatches into syscall handling (which takes
its own thread reference), so balance the reserve here. */
context_release_refcount(ctx);
context ctx = ci->m.syscall_context;
f[FRAME_VECTOR] = f[FRAME_X8];
set_current_context(ci, ctx);
Expand Down