feat: Add new apps tranche 1, pt.1 - #223
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 39 minutes and 20 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR adds three new wallet providers to the ENS Awards registry: Rabby, ReadyX (Ready), and Safe. Each includes project and app definitions, SVG icon components, and ENSv2 acceptance test benchmarks documenting resolution failures with contributor attribution and proof documentation. ChangesWallet and Project Registry Expansion
🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly Related PRs
Suggested Labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds three new Wallet-type apps — Rabby Wallet, Ready X, and Safe{Wallet} — along with their corresponding project entries, benchmark files, and proof-of-concept GIF/PNG images. All entries follow the established codebase pattern, including the
Confidence Score: 5/5Safe to merge — the changes are purely additive data entries following an established pattern, with no logic or routing changes. All three apps and their project counterparts follow the existing codebase conventions correctly. The only notable issue is that the two Rabby icon files share identical SVG gradient IDs, which creates a document-scope collision risk when both icons appear on the same page. Because the gradient definitions are currently identical, there is no visible rendering problem today, making this a maintainability concern rather than an active defect. data/apps/rabby-wallet/icon.tsx and data/projects/rabby/icon.tsx share the same linearGradient IDs and should use distinct prefixes. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Projects ["data/projects/"]
PR[rabby/index.ts\nProjectIds.Rabby] --> PRI[rabby/icon.tsx\nviewBox 0 0 512 512]
PP[ready/index.ts\nProjectIds.Ready] --> PPI[ready/icon.tsx]
PS[safe/index.ts\nProjectIds.Safe] --> PSI[safe/icon.tsx]
end
subgraph Apps ["data/apps/"]
AR[rabby-wallet/index.ts\nAppTypes.Wallet] --> ARI[rabby-wallet/icon.tsx\nviewBox 55 56 400 400]
AR --> ARB[rabby-wallet/benchmarks/index.tsx\nBenchmarkResults.Fail]
AX[readyx-wallet/index.ts\nAppTypes.Wallet] --> AXI[readyx-wallet/icon.tsx]
AX --> AXB[readyx-wallet/benchmarks/index.tsx\nBenchmarkResults.Fail]
ASW[safe-wallet/index.ts\nAppTypes.Wallet] --> ASWI[safe-wallet/icon.tsx]
ASW --> ASWB[safe-wallet/benchmarks/index.tsx\nBenchmarkResults.Fail]
end
PR -->|project ref| AR
PP -->|project ref| AX
PS -->|project ref| ASW
PRI -. "shares gradient IDs paint0-3_linear_1758_656" .-> ARI
Reviews (3): Last reviewed commit: "Apply AI agents' suggestions, pt.1" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR adds the first tranche of new Wallet apps (Safe{Wallet}, Rabby Wallet, ReadyX) to the ENSAwards data layer by introducing new ProjectIds, project definitions (with icons), app definitions (with icons), and initial benchmark entries.
Changes:
- Added three new projects (
Safe,Rabby,Ready) toProjectIdsand registered them viadefineProject. - Added three new wallet apps (
safe-wallet,rabby-wallet,readyx-wallet) registered viadefineApp. - Added initial ENS best-practice benchmark entries for the new apps, plus a small copy update to an existing WalletChan benchmark note/alt text.
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| ensawards.org/data/projects/types.ts | Adds new ProjectIds entries for Safe/Rabby/Ready. |
| ensawards.org/data/projects/safe/index.ts | Registers the Safe project metadata. |
| ensawards.org/data/projects/safe/icon.tsx | Adds the Safe project SVG icon. |
| ensawards.org/data/projects/rabby/index.ts | Registers the Rabby project metadata. |
| ensawards.org/data/projects/rabby/icon.tsx | Adds the Rabby project SVG icon. |
| ensawards.org/data/projects/ready/index.ts | Registers the Ready project metadata. |
| ensawards.org/data/projects/ready/icon.tsx | Adds the Ready project SVG icon. |
| ensawards.org/data/apps/safe-wallet/index.ts | Defines and registers the Safe{Wallet} app. |
| ensawards.org/data/apps/safe-wallet/icon.tsx | Adds the Safe{Wallet} app SVG icon. |
| ensawards.org/data/apps/safe-wallet/benchmarks/index.tsx | Adds initial benchmarks for Safe{Wallet}. |
| ensawards.org/data/apps/rabby-wallet/index.ts | Defines and registers the Rabby Wallet app. |
| ensawards.org/data/apps/rabby-wallet/icon.tsx | Adds the Rabby Wallet app SVG icon. |
| ensawards.org/data/apps/rabby-wallet/benchmarks/index.tsx | Adds initial benchmarks for Rabby Wallet. |
| ensawards.org/data/apps/readyx-wallet/index.ts | Defines and registers the ReadyX wallet app. |
| ensawards.org/data/apps/readyx-wallet/icon.tsx | Adds the ReadyX wallet app SVG icon. |
| ensawards.org/data/apps/readyx-wallet/benchmarks/index.tsx | Adds initial benchmarks for ReadyX wallet. |
| ensawards.org/data/apps/walletchan-wallet/benchmarks/index.tsx | Updates wording and alt text for an existing benchmark note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ensawards.org/data/apps/readyx-wallet/icon.tsx`:
- Around line 13-17: The <path> element defines both a fill attribute and a
style with the same fill color; remove the redundant fill attribute
(fill="`#FF875B`") from that <path> so the inline style (style={{ fill: "`#FF875B`",
fillOpacity: 1 }}) remains the single source of truth and keep the existing
fillOpacity in the style.
In `@ensawards.org/data/apps/safe-wallet/benchmarks/index.tsx`:
- Around line 19-24: Add a TODO comment above the object entries
"display-named-smart-contracts-mainnet" and
"display-named-smart-contracts-l2-chains" explaining why their inner benchmark
values are intentionally set to undefined, mirror the explanatory comment used
in rabby-wallet and readyx-wallet, and reference issue `#222` for follow-up; place
the comment next to the object entries in index.tsx so it's clear these Contract
Naming benchmarks are intentionally disabled pending that issue.
In `@ensawards.org/data/projects/ready/icon.tsx`:
- Around line 10-14: The <path> element defines the same color twice
(fill="`#FF875B`" and style={{ fill: "`#FF875B`", fillOpacity: 1 }}); remove the
redundancy by deleting one of them—either drop the fill attribute or remove the
fill from the style object—and keep the other (and ensure fillOpacity remains if
you need it) so the <path> element only specifies the fill color once.
- Line 1: The component Icon uses the React namespace in its type annotation
(React.SVGProps<SVGSVGElement>) but React is not imported; add an import for
React (e.g., import React from "react") at the top of icon.tsx so the React
namespace is available and the TypeScript error is resolved, matching the other
icon files like safe/icon.tsx and rabby/icon.tsx; ensure the import is placed
before the Icon declaration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2db52118-c0a7-4550-afc5-d5464b41e139
⛔ Files ignored due to path filters (3)
ensawards.org/data/apps/rabby-wallet/benchmarks/correctly-resolve-ensv2-test-name-address-proof.gifis excluded by!**/*.gifensawards.org/data/apps/readyx-wallet/benchmarks/correctly-resolve-ensv2-test-name-address-proof.pngis excluded by!**/*.pngensawards.org/data/apps/safe-wallet/benchmarks/correctly-resolve-ensv2-test-name-address-proof.gifis excluded by!**/*.gif
📒 Files selected for processing (17)
ensawards.org/data/apps/rabby-wallet/benchmarks/index.tsxensawards.org/data/apps/rabby-wallet/icon.tsxensawards.org/data/apps/rabby-wallet/index.tsensawards.org/data/apps/readyx-wallet/benchmarks/index.tsxensawards.org/data/apps/readyx-wallet/icon.tsxensawards.org/data/apps/readyx-wallet/index.tsensawards.org/data/apps/safe-wallet/benchmarks/index.tsxensawards.org/data/apps/safe-wallet/icon.tsxensawards.org/data/apps/safe-wallet/index.tsensawards.org/data/apps/walletchan-wallet/benchmarks/index.tsxensawards.org/data/projects/rabby/icon.tsxensawards.org/data/projects/rabby/index.tsensawards.org/data/projects/ready/icon.tsxensawards.org/data/projects/ready/index.tsensawards.org/data/projects/safe/icon.tsxensawards.org/data/projects/safe/index.tsensawards.org/data/projects/types.ts
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@Y3drk Looks good, thanks! 🚀
Lite PR → Add new apps tranche 1, pt.1
Summary
Wallettype from the spec provided by @caldonia-eth: Rabby Wallet, Ready X, and Safe{Wallet}Why
Testing
typecheck,lint, andtestcommands locally to ensure that the migration didn't break anything, and later confirmed that in our CI workflowNotes for reviewer
Pre-Review Checklist (Blocking)