Repository navigation
Add NDNCERT CA server and include system CA roots in image - #231
Closed
markverick wants to merge 2 commits into
Closed
markverick wants to merge 2 commits into
markverick wants to merge 2 commits into
Conversation
| start := notBefore.Unwrap() | ||
| end := notAfter.Unwrap() | ||
| maxValiditySeconds, err := ca.config.GetMaxValidityPeriodSeconds() | ||
| maxValidity := time.Duration(maxValiditySeconds) * time.Second |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for email and DNS-01 challenges to the NDNCERT CA server, enabling automated certificate issuance via email and DNS verification. It introduces robust implementations for both challenge types, comprehensive unit tests, and a sample configuration file. Additionally, it ensures that the Docker image includes system CA certificates for secure email delivery.
NDNCERT CA Challenge Support
Email Challenge Implementation:
ChallengeEmailHandlerandSMTPEmailSenderinchallenge_email.go, supporting secure code generation, email delivery via SMTP (with TLS), and robust validation of user input and code attempts.challenge_email_test.go.DNS-01 Challenge Implementation:
ChallengeDnsHandlerinchallenge_dns.go, allowing domain ownership verification via DNS TXT records, with support for test mocking and error handling.challenge_dns_test.go.Configuration and Integration
ca.conf.sample) demonstrating how to configure supported challenges, including SMTP details for email verification.Testing and Policy Validation
ca_policy_test.go.