packaging: produce Windows zip and NSIS installer in CI - #234
Open
dmitrymmm wants to merge 2 commits into
Open
Conversation
Windows users only had raw CI binary artifacts (myriadrf#217), no installable package (myriadrf#149). CPack now builds a versioned zip and an NSIS installer on Windows: component chooser, optional PATH entry for the CLI tools, start menu shortcut for limeGUI, uninstall before reinstall. The CI Windows job packages both and uploads them as artifacts for x64 and Win32. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RRw4BDTdy84hhSVXAREkuw
Member
|
Did you test the installer? Does it take care of C++ redistributable runtime libraries? |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RRw4BDTdy84hhSVXAREkuw
Contributor
Author
|
Runtime DLLs are bundled now (InstallRequiredSystemLibraries). The installer itself is only CI-built so far, I'll run the artifact on a Windows machine and report back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #149. CI already uploads raw Windows binaries (#217); this adds a versioned zip and an NSIS installer built by CPack and uploaded as artifacts for x64 and Win32: component chooser, optional PATH entry for the CLI tools, start menu shortcut for limeGUI, uninstall before reinstall. Publishing them as release assets can follow once v1.0.0-rc1 is tagged.
🤖 Generated with Claude Code