Skip to content

LMS_SetNCOFrequency and LMS_GetNCOFrequency dereference the table without a null check #403

Description

@dmitrymmm

LMS_SetNCOFrequency reads freq[i] for all 16 entries and LMS_GetNCOFrequency writes freq[i], neither checking the pointer, while the companion pho pointer is guarded in the getter. Legacy LimeSuite guarded both with if (freq != nullptr), explicitly allowing a null table to mean "set/read only the phase offset", and the sibling LMS_SetNCOPhase / LMS_GetNCOPhase in this same file already guard their array pointer.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions