Skip to content

feat: PEG-2146 more formats support and ccapi doc update#34

Closed
hmeng1024 wants to merge 12 commits into
mycloudnexus:mainfrom
hmeng1024:main
Closed

feat: PEG-2146 more formats support and ccapi doc update#34
hmeng1024 wants to merge 12 commits into
mycloudnexus:mainfrom
hmeng1024:main

Conversation

@hmeng1024

@hmeng1024 hmeng1024 commented Jul 16, 2025

Copy link
Copy Markdown

This (first 3 points below) was done sometime ago, but i forgot to do the fork PR at that time.

  • Would start to open this door with later possible more api doc json update

Updates

  1. specs/ccapi_uat_20241025.json vs specs/cc_api_uat_20241025_update.json

    • ccapi_uat_20241025.json is the original openapi json file downloaded from uat api doc page (on 25/10)
    • cc_api_uat_20241025_update.json is the real one to deploy
      • It has been tweaked with 10+ validation errors (from addtionalProperty vs $ref) - details see vimdiff in ccapi_uat_update_diff_by1025.html (temp tracked from git)
      • SPEC_FILE=./specs/cc_api_uat_20241025_update.json docker compose up --build
  2. update in compose.yml to allow SPEC_FILE to pass in

  3. some debug 'prints' in app.ts, which could be removed later

  4. new from 20250716 👇

  5. PEG-2146 from 20250716 👇

    • Added support for string formats using ajv-formats.
    • Added custom formats - ObjectId, hostname, JSON and datetime (YYYY-MM-DDTHH:mm:ss.sssZ) with validators
    • ajv format ref -> https://ajv.js.org/guide/formats.html

@hmeng1024 hmeng1024 changed the title ccapi doc update feat: PEG-2146 more formats support and ccapi doc update Jul 16, 2025
@AnnaGerber

Copy link
Copy Markdown
Collaborator

Looks like the yarn lock file might need updating - try yarn install?

@AnnaGerber

Copy link
Copy Markdown
Collaborator

The failing test is flagging the following deps contain vulnerabilities:

Library Vulnerable version Severity Fix version Vulnerability ID
form-data 4.0.3 Critical 🔴 4.0.4 GHSA-fjxv-7rqg-78g4
@eslint/plugin-kit 0.3.3 Low 0.3.4 GHSA-xffm-g5w8-qvg7

Comment thread package.json Outdated
"wait-on": "^8.0.1"
},
"dependencies": {
"@eslint/plugin-kit": "^0.3.4",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's behind us adding this as a dependency? Usually this package is for eslint plugins. It at least should definitely be a devDependency, but I would be very surprised if we should have this dependency at all. It's also locked to a very old version of this plugin (currently they are on major version 11).

Comment thread src/app.ts Outdated
Comment on lines +46 to +49
// Debug: log every incoming request
app.use((req, res, next) => {
next();
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the intent of this middleware? it seems to do nothing

@sonarqubecloud

Copy link
Copy Markdown

@hmeng1024

Copy link
Copy Markdown
Author

Thank you for all your attentions and helps!
This PR has been 'migrated' to #35 by @james-garrett to solve some ut errors.
Closing this #34 now

@hmeng1024 hmeng1024 closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants