Skip to content

Class proxy#165

Open
daycry wants to merge 1 commit into
myclabs:1.xfrom
daycry:patch-1
Open

Class proxy#165
daycry wants to merge 1 commit into
myclabs:1.xfrom
daycry:patch-1

Conversation

@daycry

@daycry daycry commented Aug 4, 2021

Copy link
Copy Markdown

The proxy class in doctrine is different

The proxy class in doctrine is different
@sstutz

sstutz commented Aug 25, 2021

Copy link
Copy Markdown

+1 this change is needed in order to make DeepCopy work with recent releases of doctrine.

@mnapoli

mnapoli commented Aug 26, 2021

Copy link
Copy Markdown
Member

Thanks. Ideally we should support both versions, here I guess it will break backward compatibility.

@daycry

daycry commented Aug 26, 2021

Copy link
Copy Markdown
Author

Hello, I understand you, but a lot of people upgrade doctrine version for improve our features like me.

I only want help us but is your Code.

Thank you for your answers.

@sstutz

sstutz commented Aug 26, 2021

Copy link
Copy Markdown

then change was introduced in v2 https://github.com/doctrine/persistence/blob/3.0.x/UPGRADE-2.0.md
so I guess we could do something like

if (persistence >= v2) { $obj instanceof Proxy } else { $obj instanceof Common\Proxy }

@mnapoli thoughts?

@mnapoli

mnapoli commented Aug 26, 2021

Copy link
Copy Markdown
Member

No particular thoughts, I don't know if that would work by just looking at this example to be honest. Feel free to test/investigate, I won't have time to invest into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants