Repository navigation
chore: update media3 to 1.11.0 and Mux Data to 1.13.2 - #107
Merged
Merged
Conversation
media3 1.11.0 added HLS Content Steering, which appends a nullable ContentSteeringInfo parameter to the HlsMultivariantPlaylist constructor. Only a test fixture constructs that type, so it just passes null; the offline code only reads playlists. Mux Data's artifact coordinate is pinned to the media3 minor version, so data-media3-at_1_10 becomes data-media3-at_1_11. Mux Data 1.13.2 adds media3 1.11.x support. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
AI Review Classification —
|
| Layer | Result |
|---|---|
| Rules (engine) | score 3.8 (low) |
| Routing | route-to-llm |
| Learned calibration | 4.3 (medium) |
| LLM judge | 3.4 (low) — Minor dependency bump of media3 and Mux Data with a corresponding test constructor update for a new HLS content-steering parameter; low blast radius and easily reversible, though playback-SDK upgrades can carry subtle behavioral changes that merit smoke testing. |
Full audit — which factors fired and why
PR Risk Assessment — LOW (score 3.8/10)
Signals observed:
production_repo(+0.3) — pull request targets a production repository [stacking decay x0.6 at rank 3]gradle_build_chain(+1.0) — core build-system change (gradle/libs.versions.toml)dependency_bump(+2.5) — framework dependency change in gradle/libs.versions.toml (/(?i)media3.*\d+.\d+/)
Reductions applied:
- none
Scoring:
- base (inherent): 3.8
- after reductions: 3.8
- binding floor: none
- final: 3.8 → low
⚠️ Low after reductions, not inherently low. Risk signals fired (see above) but reductions brought the score below the medium threshold. Review the suppressed signals before relying on this.
Recommended review: review:low — automated AI review is sufficient; no human required.
Grade this call — react on this comment: 👍 right · 👎 wrong · 🚀 graded too low · 👀 graded too high.
Strongly disagree? Reply /ai-review disagree should=<trivial|low|medium|high> <reason>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates both dependencies to their latest stable releases:
The Mux Data artifact coordinate is pinned to the media3 minor version, so
data-media3-at_1_10becomesdata-media3-at_1_11. Mux Data 1.13.2 exists specifically to add media3 1.11.x support.One code change was needed
media3 1.11.0 adds HLS Content Steering and Pathway Cloning, which appended a 13th nullable
ContentSteeringInfoparameter to theHlsMultivariantPlaylistconstructor. That broke one test fixture inMuxHlsDownloadCallbackTests, which now passesnull.No main-source changes: our offline code only ever reads multivariant playlists (
CapturingHlsPlaylistParserFactory, andMuxHlsDownloadCallbackbuildingStreamKeys) and never constructs them.Changelog review
I checked both changelogs for anything affecting the offline download / DRM work that just landed in #106. Nothing does:
audiotrackchangeevents, play/pause fixes for non-ExoPlayerPlayers, and a generic-bounds tightening onmonitorWithMuxData(*->Player) that compiles clean here.Testing
assembleDebugsucceeds for all modules, plus theautomatedtestsinstrumentation APKandroidx.media3:*:1.11.0anddata-media3-at_1_11:1.13.2Note for release notes
The Mux Data artifact coordinate change is consumer-visible for anyone who depends on Mux Data directly alongside this SDK.
🤖 Generated with Claude Code
Note
Low Risk
Dependency version bumps with a single test-only constructor fix; main offline/DRM paths do not construct multivariant playlists.
Overview
Bumps androidx.media3 from 1.10.1 to 1.11.0 and Mux Data from 1.12.0 to 1.13.2, and switches the Mux artifact from
data-media3-at_1_10todata-media3-at_1_11so it matches the Media3 minor version.The only source change is in
MuxHlsDownloadCallbackTests: theHlsMultivariantPlaylisttest fixture now passescontentSteeringInfo = nullfor Media3 1.11’s new constructor parameter (HLS Content Steering). Production offline/HLS code is unchanged.Reviewed by Cursor Bugbot for commit 9b51cbb. Bugbot is set up for automated code reviews on this repo. Configure here.