Repository navigation
NAT-551: Fix edit-list inspection and frame-rate precision - #174
Merged
eugene-mux merged 1 commit intoNov 4, 2026
Merged
Conversation
daytime-em
approved these changes
Nov 4, 2026
eugene-mux
merged commit Nov 4, 2026
ce95ac9
into
feature/nat-534-hevc-standard-ingest
4 checks passed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two correctness issues found during HEVC/4K acceptance testing: a captured Pixel HLG video fell back before tone mapping, and a true 60 fps source could be unnecessarily converted to 30 fps.
Changes
Validation
Note
Medium Risk
Changes core ISO timeline proofing and frame-rate measurement that drive convert-vs-upload decisions; scope is bounded by stricter edit rules and new tests, but misclassification could still affect real device captures.
Overview
Fixes two upload-planning correctness bugs from HEVC/4K acceptance: sources with a leading empty edit (common A/V gap on phone recordings) were treated as unsupported, and true 60/120 fps streams could measure slightly above policy and trigger unnecessary downconversion.
ISO edit-list handling now proves exactly one optional empty edit followed by one unit-rate media edit. The reader shifts timelines by the movie-time gap, preserves audio/video start offset, and extends
PlatformTimestampMatcherwith a per-track rounded-gap convention so extractors that snap the gap to the nearest media tick still pass a full-sample consistency check. Other edit patterns (multiple media edits, repeated empties) stay explicitly unproven.Measured frame rate in
VideoSampleFactsReaderuses the effective presentation span in container seconds instead of a span derived from microsecond-rounded PTS endpoints, avoiding boundary drift (e.g. 60 → 60.000004 fps) that failed frame-rate compliance and forced 30 fps output.Regression tests cover leading empty audio edits, rejected complex edit lists, and 60/120/60.01 fps planning at 4K.
Reviewed by Cursor Bugbot for commit a8675ed. Bugbot is set up for automated code reviews on this repo. Configure here.