Repository navigation
NAT-543: Add and retain Standard Input options - #164
Merged
eugene-mux merged 5 commits intoOct 16, 2026
Merged
eugene-mux merged 5 commits into
eugene-mux merged 5 commits into
Conversation
daytime-em
approved these changes
Oct 12, 2026
eugene-mux
merged commit Oct 16, 2026
188a0f0
into
feature/nat-534-hevc-standard-ingest
3 checks passed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 1440p resolution preset and public HDR handling options. Fixes option retention across Builder calls, upload lifecycle updates, and cached-upload restoration, and persists the new settings.
Compatibility
whenexpressions overMaximumResolutionmust handle the new preset.Current limitations
Validation
Note
Medium Risk
Touches upload configuration, persistence schema, and a new public enum/preset; behavior of actual transcoding is mostly unchanged, but restored uploads now carry different cached metadata.
Overview
Expands Standard Input configuration on
MuxUpload.Builder: addsMaximumResolution.Preset2560x1440, a publicHdrHandlingenum (Preserve/ToneMapToSDR), andhdrHandling()to store the choice alongside existing standardization toggles.Retention and persistence are the main behavioral fixes: standardization setters now merge into existing
InputStandardizationinstead of replacing unrelated fields;UploadInfo.updatedefaults preserve the current options; and SharedPreferences JSON now round-tripsinput_standardization(with safe defaults for legacy or partial records).Docs clarify that resolution still feeds the legacy transcoder (no guaranteed output size) and HDR is stored only until the new Standard Input pipeline ships. Kotlin clients with exhaustive
whenonMaximumResolutionmust handle the new preset.Adds
kotlinx-coroutines-testand Robolectric coverage for builder defaults, persistence edge cases, and lifecycle pause/resume/cache restore with options intact.Reviewed by Cursor Bugbot for commit 31fe520. Bugbot is set up for automated code reviews on this repo. Configure here.