Skip to content

Add test in 4.7 #33243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RomanPudashkin merged 1 commit into from
May 4, 2026
+40 −0
Merged

Add test in 4.7 #33243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions src/engraving/tests/chordsymbol_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,16 @@
#include "engraving/dom/part.h"
#include "engraving/dom/score.h"
#include "engraving/dom/segment.h"
#include "engraving/editing/editdata.h"
#include "engraving/editing/transpose.h"

#include "utils/scorerw.h"
#include "utils/scorecomp.h"

using namespace mu::engraving;

static constexpr double POSITION_ERROR = 1e-6;

static const String CHORDSYMBOL_DATA_DIR("chordsymbol_data/");

class Engraving_ChordSymbolTests : public ::testing::Test
Expand Down Expand Up @@ -140,6 +143,43 @@ TEST_F(Engraving_ChordSymbolTests, testAddLink)
test_post(score, u"add-link");
}

TEST_F(Engraving_ChordSymbolTests, harmonyEditKeepsDisplayPosition)
{
MasterScore* score = test_pre(u"add-link");
ASSERT_TRUE(score);

Segment* seg = score->firstSegment(SegmentType::ChordRest);
ASSERT_TRUE(seg);
ChordRest* cr = seg->cr(0);
ASSERT_TRUE(cr);

Harmony* harmony = new Harmony(cr->segment());
harmony->setHarmony(u"C");
harmony->setTrack(cr->track());
harmony->setParent(cr->segment());
score->undoAddElement(harmony);
score->doLayout();

const double x = harmony->canvasPos().x();
const double y = harmony->canvasPos().y();

EditData ed;
harmony->startEdit(ed);

EXPECT_NEAR(harmony->canvasPos().x(), x, POSITION_ERROR);
EXPECT_NEAR(harmony->canvasPos().y(), y, POSITION_ERROR);

ed.s = String(u"7");
harmony->cursor()->moveCursorToEnd();
harmony->edit(ed);

EXPECT_NEAR(harmony->canvasPos().x(), x, POSITION_ERROR);
EXPECT_NEAR(harmony->canvasPos().y(), y, POSITION_ERROR);

harmony->endEdit(ed);
delete score;
}

TEST_F(Engraving_ChordSymbolTests, testAddPart)
{
MasterScore* score = test_pre(u"add-part");
Expand Down
Loading