Fix #33088: Time signature properties crash

src/palette/widgets/customizekitdialog.cpp

@@ -154,8 +154,6 @@ CustomizeKitDialog::CustomizeKitDialog(QWidget* parent)
     drumNote->setDrawGrid(false);
     drumNote->setReadOnly(true);
 
-    QTreeWidgetItem* itemToSelect = loadPitchesList();
-
     for (auto g : noteHeadNames) {
         noteHead->addItem(TConv::translatedUserName(g), int(g));
     }
@@ -259,9 +257,6 @@ CustomizeKitDialog::CustomizeKitDialog(QWidget* parent)
     connect(customGbox, &QGroupBox::toggled, this, &CustomizeKitDialog::customGboxToggled);
     connect(quarterCmb, &QComboBox::currentIndexChanged, this, &CustomizeKitDialog::customQuarterChanged);
 
-    Q_ASSERT(pitchList->topLevelItemCount() > 0);
-    pitchList->setCurrentItem(itemToSelect ? itemToSelect : pitchList->topLevelItem(0));
-
     quarterCmb->setAccessibleName(quarterLbl->text() + " " + quarterCmb->currentText());
     halfCmb->setAccessibleName(halfLbl->text() + " " + halfCmb->currentText());
     wholeCmb->setAccessibleName(wholeLbl->text() + " " + wholeCmb->currentText());
@@ -279,6 +274,13 @@ void CustomizeKitDialog::componentComplete()
     }
 
     initDrumsetAndKey();
+
+    QTreeWidgetItem* itemToSelect = loadPitchesList();
+    itemToSelect = itemToSelect ? itemToSelect : pitchList->topLevelItem(0);
+
+    if (itemToSelect) {
+        pitchList->setCurrentItem(itemToSelect);
+    }
 }
 
 //---------------------------------------------------------

src/palette/widgets/noteGroups.cpp

@@ -81,6 +81,11 @@ NoteGroups::NoteGroups(QWidget* parent)
     : QGroupBox(parent), muse::Contextable(muse::iocCtxForQWidget(this))
 {
     setupUi(this);
+}
+
+void NoteGroups::classBegin()
+{
+    iconPalette->classBegin();
 
     iconPalette->setName(QT_TRANSLATE_NOOP("palette", "Beam selector"));
     iconPalette->setGridSize(27, 40);
@@ -109,6 +114,11 @@ NoteGroups::NoteGroups(QWidget* parent)
     connect(view32, &NoteGroupsExampleView::beamPropertyDropped, this, &NoteGroups::beamPropertyDropped);
 }
 
+void NoteGroups::componentComplete()
+{
+    iconPalette->componentComplete();
+}
+
 void NoteGroups::setSig(Fraction sig, const Groups& g, const QString& z, const QString& n)
 {
     _sig    = sig;

src/palette/widgets/noteGroups.h

@@ -59,6 +59,10 @@ private slots:
 
 public:
     NoteGroups(QWidget* parent);
+
+    void classBegin();
+    void componentComplete();
+
     void setSig(engraving::Fraction sig, const engraving::Groups&, const QString& zText, const QString& nText);
     engraving::Groups groups();
 };

src/palette/widgets/palettewidget.cpp

@@ -77,7 +77,8 @@ using namespace muse::actions;
 PaletteWidget::PaletteWidget(QWidget* parent)
     : QWidget(parent), muse::Contextable(muse::iocCtxForQWidget(this))
 {
-    m_palette = std::make_shared<Palette>(iocContext());
+    //! NOTE: set ioc ctx later
+    m_palette = std::make_shared<Palette>(nullptr);
 
     //! NOTE: need for accessibility
     m_palette->setParent(this);
@@ -88,6 +89,16 @@ PaletteWidget::PaletteWidget(QWidget* parent)
     setMouseTracking(true);
 }
 
+void PaletteWidget::classBegin()
+{
+    m_palette->setContext(iocContext());
+}
+
+void PaletteWidget::componentComplete()
+{
+    // noop
+}
+
 void PaletteWidget::setPalette(PalettePtr palette)
 {
     if (!palette) {

src/palette/widgets/palettewidget.h

@@ -178,6 +178,9 @@ class PaletteWidget : public QWidget, public muse::async::Asyncable, public muse
     const PaintOptions& paintOptions() const;
     void setPaintOptions(const PaintOptions& options);
 
+    void classBegin();
+    void componentComplete();
+
 signals:
     void changed();
     void boxClicked(int index);

src/palette/widgets/timesignaturepropertiesdialog.cpp

@@ -56,8 +56,10 @@ TimeSignaturePropertiesDialog::~TimeSignaturePropertiesDialog()
     delete m_editedTimeSig;
 }
 
-void TimeSignaturePropertiesDialog::componentComplete()
+void TimeSignaturePropertiesDialog::classBegin()
 {
+    groups->classBegin();
+
     QString musicalFontFamily = QString::fromStdString(uiConfiguration()->musicalFontFamily());
     int musicalFontSize = uiConfiguration()->musicalFontSize();
 
@@ -165,6 +167,11 @@ void TimeSignaturePropertiesDialog::componentComplete()
     groups->setSig(m_editedTimeSig->sig(), g, m_editedTimeSig->numeratorString(), m_editedTimeSig->denominatorString());
 }
 
+void TimeSignaturePropertiesDialog::componentComplete()
+{
+    groups->componentComplete();
+}
+
 void TimeSignaturePropertiesDialog::showEvent(QShowEvent* event)
 {
     WidgetStateStore::restoreGeometry(this);

src/palette/widgets/timesignaturepropertiesdialog.h

@@ -48,6 +48,7 @@ class TimeSignaturePropertiesDialog : public muse::ui::WidgetDialog, public Ui::
     TimeSignaturePropertiesDialog(QWidget* parent = nullptr);
     ~TimeSignaturePropertiesDialog() override;
 
+    void classBegin() override;
     void componentComplete() override;
 
 private slots: