Skip to content

Fix #32261: Add zoom orientation for list type selections #33135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shrutiba1 wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

Fix #32261: Add zoom orientation for list type selections #33135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/notationscene/qml/MuseScore/NotationScene/notationviewinputcontroller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include <QQuickItem>
#include <QTimer>
#include <QtMath>

#include "defer.h"
#include "log.h"

Expand Down Expand Up @@ -337,6 +336,14 @@ PointF NotationViewInputController::findZoomFocusPoint() const
// No selection: zoom at the center of the view
resultX = m_view->width() / 2;
resultY = m_view->height() / 2;
} else if (selection->state() == mu::engraving::SelState::LIST) {
RectF rectResult;
for (const mu::engraving::EngravingItem* element : selection->elements()) {
rectResult = rectResult.united(element->canvasBoundingRect());
}
PointF result = m_view->fromLogical(rectResult.center());
resultX = result.x();
resultY = result.y();
} else {
// Selection: zoom at the center of the selection
PointF result = m_view->fromLogical(selection->canvasBoundingRect().center());
Copy link
Copy Markdown
Contributor

@mathesoncalum mathesoncalum Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think NotationSelection::canvasBoundingRect would actually be the most coherent place for your newly added LIST logic. After a quick search it looks like findZoomFocusPoint is the only place we use this method (you may want to double check that), so I think we're safe to do so.

Expand Down
Loading